Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove upper limit on version of SciPy and fix resulting test failures #2474

Closed
namurphy opened this issue Jan 22, 2024 · 0 comments · Fixed by #2475
Closed

Remove upper limit on version of SciPy and fix resulting test failures #2474

namurphy opened this issue Jan 22, 2024 · 0 comments · Fixed by #2475
Labels
bug Issues describing unexpected behavior or defects. Remember: a bug is a sign of a missing test!
Milestone

Comments

@namurphy
Copy link
Member

In #2472, updating to scipy == 1.12.0 led to four new errors in test_grids.py. I'm not sure what the cause is, but it'd be worth reading through the release notes for SciPy 1.12.0. It'd be really helpful to get this fixed before releasing 2024.1.0 next week.

The errors are:

__________________________________ test_nonuniform_cartesian_NN_interp[pos0-quantities0-expected0] __________________________________
tests/test_grids.py:710: in test_nonuniform_cartesian_NN_interp
pout = nonuniform_cartesian_grid.nearest_neighbor_interpolator(pos, *quantities)
../utils/decorators/helpers.py:58: in wrapper
return f(*bound_args.args, **bound_args.kwargs)
grids.py:1423: in nearest_neighbor_interpolator
vals = self._interp_quantities[i, :]
E   IndexError: arrays used as indices must be of integer (or boolean) type
__________________________________ test_nonuniform_cartesian_NN_interp[pos1-quantities1-expected1] __________________________________
tests/test_grids.py:710: in test_nonuniform_cartesian_NN_interp
pout = nonuniform_cartesian_grid.nearest_neighbor_interpolator(pos, *quantities)
../utils/decorators/helpers.py:58: in wrapper
return f(*bound_args.args, **bound_args.kwargs)
grids.py:1423: in nearest_neighbor_interpolator
vals = self._interp_quantities[i, :]
E   IndexError: arrays used as indices must be of integer (or boolean) type
__________________________________ test_nonuniform_cartesian_NN_interp[pos2-quantities2-expected2] __________________________________
tests/test_grids.py:710: in test_nonuniform_cartesian_NN_interp
pout = nonuniform_cartesian_grid.nearest_neighbor_interpolator(pos, *quantities)
../utils/decorators/helpers.py:58: in wrapper
return f(*bound_args.args, **bound_args.kwargs)
grids.py:1423: in nearest_neighbor_interpolator
vals = self._interp_quantities[i, :]
E   IndexError: arrays used as indices must be of integer (or boolean) type
______________________________________ test_nonuniform_cartesian_nearest_neighbor_interpolator ______________________________________
tests/test_grids.py:736: in test_nonuniform_cartesian_nearest_neighbor_interpolator
pout = grid.nearest_neighbor_interpolator(pos, "x", persistent=True)
../utils/decorators/helpers.py:58: in wrapper
return f(*bound_args.args, **bound_args.kwargs)
grids.py:1423: in nearest_neighbor_interpolator
vals = self._interp_quantities[i, :]
E   IndexError: arrays used as indices must be of integer (or boolean) type
@namurphy namurphy added this to the v2024.1.0 milestone Jan 22, 2024
@namurphy namurphy added the bug Issues describing unexpected behavior or defects. Remember: a bug is a sign of a missing test! label Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues describing unexpected behavior or defects. Remember: a bug is a sign of a missing test!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant