Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Expose target and browser to process.env #133

Closed
3 tasks done
louisgv opened this issue Aug 10, 2022 · 0 comments · Fixed by #136
Closed
3 tasks done

[RFC] Expose target and browser to process.env #133

louisgv opened this issue Aug 10, 2022 · 0 comments · Fixed by #136
Assignees
@louisgv
Labels
enhancement New feature or request

Comments

@louisgv
Copy link
Contributor

louisgv commented Aug 10, 2022

How do you envision this feature/change to look/work like?

process.env.PLASMO_TARGET === "chrome-mv3"

process.env.PLASMO_BROWSER === "chrome"

process.env.PLASMO_MANIFEST_VERSION === "mv3"

What is the purpose of this change/feature? Why?

https://discord.com/channels/946290204443025438/1006923584142315542/1006923592069554176

(OPTIONAL) Example implementations

No response

(OPTIONAL) Contact Details

No response

Verify canary release

  • I verified that the issue exists in plasmo canary release

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I checked the current issues for duplicate problems.
@louisgv louisgv added the enhancement New feature or request label Aug 10, 2022
@louisgv louisgv self-assigned this Aug 10, 2022
@louisgv louisgv mentioned this issue Aug 13, 2022
Merged
4 tasks
@louisgv louisgv linked a pull request Aug 13, 2022 that will close this issue
feat: expose target data to env #136
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@louisgv louisgv

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: expose target data to env PlasmoHQ/plasmo
1 participant
@louisgv