Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] @plasmohq/devtools #28

Open
3 tasks done
ColdSauce opened this issue Jun 15, 2022 · 3 comments
Open
3 tasks done

[RFC] @plasmohq/devtools #28

ColdSauce opened this issue Jun 15, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed polling For issues where the community is to be polled

Comments

@ColdSauce
Copy link
Contributor

How do you envision this feature/change to look/work like?

We have DevTools support, but we need to think about how to best integrate the sub-components like Panels, etc.

What is the purpose of this change/feature? Why?

Right now, DevTools isn't supported very well with Plasmo.

(OPTIONAL) Example implementations

TODO

(OPTIONAL) Contact Details

No response

Verify canary release

  • I verified that the issue exists in plasmo canary release

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I checked the current issues for duplicate problems.
@ColdSauce ColdSauce added the enhancement New feature or request label Jun 15, 2022
@ColdSauce ColdSauce changed the title RFC | DevTools Panel AI RFC | DevTools Panel API Jun 15, 2022
@ColdSauce ColdSauce assigned ColdSauce and unassigned ColdSauce Jun 15, 2022
@ColdSauce ColdSauce added the help wanted Extra attention is needed label Jun 15, 2022
@louisgv louisgv changed the title RFC | DevTools Panel API [RFC] DevTools Panel API Jun 29, 2022
@louisgv louisgv self-assigned this Jul 15, 2022
@louisgv louisgv changed the title [RFC] DevTools Panel API [RFC] @plasmohq/devtools Aug 17, 2022
@ptim
Copy link

ptim commented Aug 17, 2022

Thanks for Plasmo!

FYI for some reason when I relocate the with-devtools example into src/ following https://docs.plasmo.com/customization#using-the-src-directory-for-source-code, then I get the following build error:

🔴 ERROR  | Failed to resolve 'url:\~/panels/font-picker/index.html' from './src/devtools.tsx'
          | import fontPickerHTML from "url:~/panels/font-picker/index.html"

which is resolved by using a relative rather than aliased import path like:

import fontPickerHTML from "url:./panels/font-picker/index.html"

I wonder if this has to do with the "url:" prefix, which I haven't gotten to the bottom of yet...

@louisgv
Copy link
Contributor

louisgv commented Aug 17, 2022

@ptim thanks for the report - I will update the example to use relative import rather than tilde resolve!

To read more about the scheme and the tilde import, please take a look at https://docs.plasmo.com/browser-extension/import#tilde-

Basically, since it wasn't a source import (ts/tsx), to use tilde, you would have to do ~/src/panels/etc.... For this case, relative import makes most sense tho!

@louisgv louisgv added the polling For issues where the community is to be polled label Aug 22, 2022
@louisgv
Copy link
Contributor

louisgv commented Oct 8, 2022

Since the advent of #231, I'm not sure if we need to focus on this anymore - we can perhaps refactor devtools example to use the tabs feature and it should just work with minimal configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed polling For issues where the community is to be polled
Projects
None yet
Development

No branches or pull requests

3 participants