Frontend challenge - Sergio Alonzo Piña #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview
Steps that i took to solve the challengue:
1- make the components, add the layers and make the structure, i used material-ui library to make it easier.
2- make the getData function, i wanted to use axios but i did't make it work so i decided to use normal fetch function.
3- after the getData function i made some tests to see if all works, then i used propTypes to pass the API data to the components.
4- i added my own data in the json file.
5- i fixed some things that make bugs on the tests from jest and i updated the node modules.
6- more fixing and tests, to integrate server API and my app.
the design was simple but according to the rules, i didn't have too much time to make it prettier, but it works