Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abandoned, please delete or close this issue, thanks #1239

Open
Coresi7 opened this issue Nov 30, 2023 · 39 comments
Open

Abandoned, please delete or close this issue, thanks #1239

Coresi7 opened this issue Nov 30, 2023 · 39 comments
Labels
app-support Support for additional non gaming apps documentation Improvements or additions to documentation

Comments

@Coresi7
Copy link

Coresi7 commented Nov 30, 2023

Abandoned, please delete or close this issue, thanks

@Coresi7 Coresi7 added the app-support Support for additional non gaming apps label Nov 30, 2023
@TheMoonThatRises
Copy link
Member

TheMoonThatRises commented Nov 30, 2023

You can take a look at this issue which currently tracks the issue: #1104. I'm not sure as to why the name specifically causes the app to crash, but you could look into that. As to not pretend to be a certain device model, that could be possible, but I personally am not certain.

@TheMoonThatRises TheMoonThatRises added the documentation Improvements or additions to documentation label Nov 30, 2023
@Coresi7

This comment was marked as outdated.

@XuYicong
Copy link
Member

XuYicong commented Nov 30, 2023

For game dev, you can test with playtools removed to avoid bypassing behaviours like faking device model.
图片
In this interface, click 移除PlayTools, and then you can test your own adaptations like keyboard, touchpad and shaders.

I think the Chinese name crashing is an issue on our side, cause it also happens to 崩坏3 and 崩坏:星穹铁道. But we have little knowledge on it. You're welcome to open PRs to help us solve this issue.

But as for the crash report specifically in your screenshot, that's probably some fault in playtools, not the naming affairs. That should be a separate issue and should be investigated separately.

Basically playtools is a dylib that's injected to the game when installing. You can consider it a 善意外挂. If any problem persists even when playtools removed (and cannot reproduce without playcover), that's probably something wrong with the app install procedures of playcover. You can check PlayCover/AppInstaller/Installer.swift for details. I suspect there are some pathing mistakes in this.

You may also try Sideloadly, another sideloading software similar to playcover but with less functionality but (possibly) more stable. Playcover can also "export to sideloadly" for an app. You can try multiple combinations to get a clue to locate the cause.

@Keep-hair-loss
Copy link

First of all, thanks for your help. My system is macOS Sonoma 14.1.1
The game works, but I can't use the microphone to communicate with my teammates. I've given jkchess access to the microphone.
WX20231201-111025@2x

That's what the game reminds me.
WX20231201-111207@2x

首先感谢您可以提供帮助,我的系统是macOS Sonoma 14.1.1。
游戏可以正常运行,但是我是用不了麦克风和队友交流。我已经给jkchess麦克风权限。

@Coresi7

This comment was marked as outdated.

@Coresi7

This comment was marked as outdated.

@Keep-hair-loss
Copy link

游戏内音频支持我们是使用Gvoice sdk提供的支持,我可以帮你问问他们并且测试这个功能是否在mac可用。但我们至少春节版本应该没有更新sdk的计划,故如果真因为sdk出的问题,或许可能需要若干个大版本解决,但如果是因为我们自己的问题,我们想想办法。
麻烦参考我第二个回应来尝试上传一下日志并提供uid,注意,不是qq或者微信id,这有助于保护你的隐私。

感谢您可以回复我的问题关于在macOS Sonoma 14.1.1 上运行游戏无法使用麦克风,也感谢你可以用中文回复我,我的游戏UID是 2866590996

我在登陆界面上传了日志,希望对你们改进游戏能有有效的帮助。

Uid
上报日志

Thank you for replying to my question about the inability to use the microphone when running the game on macOS Sonoma 14.1.1, and thank you for replying to me in Chinese, my game UID is 2866590996.
I uploaded the log on the login interface, I hope it can be of effective help to you to improve the game.

@Coresi7

This comment was marked as outdated.

@Coresi7

This comment was marked as outdated.

@Coresi7
Copy link
Author

Coresi7 commented Dec 4, 2023

You can take a look at this issue which currently tracks the issue: #1104. I'm not sure as to why the name specifically causes the app to crash, but you could look into that. As to not pretend to be a certain device model, that could be possible, but I personally am not certain.

The Chinese name crash is reproducable under playcover even in our dev version, but I cannot reproduce it in xcode build env, or run it without playcover by our enterprise apple signiture. Please give me way to try to run it debuggable in playcover, otherwise I can't extract stacktrace and help you to fix this issue.

@XuYicong
Copy link
Member

XuYicong commented Dec 4, 2023

I know what you mean, I caught a crash when using Chinese name with playcover, maybe you may tell me how to run our game via xcode using playcover, I have to try to debug it under playcover env, because I can't reproduce it via xcode run, so I cannot extract stacktrace symbol there.

You can build PlayCover using xcode, then run your game via that xcode build version of PlayCover. The whole process tree would be in xcode-debug env.

@ohaiibuzzle
Copy link
Member

ohaiibuzzle commented Dec 5, 2023

The Chinese name crash is reproducable under playcover even in our dev version, but I cannot reproduce it in xcode build env, or run it without playcover by our enterprise apple signiture. Please give me way to try to run it debuggable in playcover, otherwise I can't extract stacktrace and help you to fix this issue.

To be completely fair to you this is our issue that we should fix properly on PlayCover (We went to naming the app bundle using the same as its actual name in 2.0). It’s not something you’d ever expect (on iOS they are always guaranteed to be UUID using ASCII characters)

@Coresi7

This comment was marked as outdated.

@Coresi7

This comment was marked as outdated.

@Coresi7

This comment was marked as outdated.

@ohaiibuzzle
Copy link
Member

ohaiibuzzle commented Dec 5, 2023

It's very kindly of you to tell me that, however we are under investigating what we can do to make a hotfix workaround instead of letting player change the name of our product.

A hack I can come up with is basically to export the ipa with its CFDisplayName key modified, it's how PlayCover determines where to put the finalized app bundle. Since PlayCover deals with unsigned apps anyway, it's not like this would matter much

static func wrap(_ baseApp: BaseApp) throws -> URL {

I'll see if there is a feasible way that we can convert all existing app bundle to CFBundleName instead of CFDisplayName, it would reduce headache for titles like Honkai Impact 3rd CN as well

@Coresi7
Copy link
Author

Coresi7 commented Dec 5, 2023

It's very kindly of you to tell me that, however we are under investigating what we can do to make a hotfix workaround instead of letting player change the name of our product.

A hack I can come up with is basically to export the ipa with its CFDisplayName key modified, it's how PlayCover determines where to put the finalized app bundle. Since PlayCover deals with unsigned apps anyway, it's not like this would matter much

static func wrap(_ baseApp: BaseApp) throws -> URL {

I'll see if there is a feasible way that we can convert all existing app bundle to CFBundleName instead of CFDisplayName, it would reduce headache for titles like Honkai Impact 3rd CN as well

Thanks, I'll look into it.

@Coresi7

This comment was marked as outdated.

@ohaiibuzzle
Copy link
Member

ohaiibuzzle commented Dec 5, 2023

Okay that one is legitimately… weird.

The Containers folders are actually not named using Unicode characters, if you open a terminal to it, they will actually use bundle IDs. macOS is just showing them as the app name in the Finder

@XuYicong
Copy link
Member

XuYicong commented Dec 5, 2023

bro I wonder if it's ok to leak your private code publicly. btw that 顺手提前检查一下 looks pretty weird, generally you don't do things by 顺手 in coding, that's definitely bringing unnecessary complexity with very little benefit. It not only decrease your branch coverage during testing aka. make testing harder, but also brings extra recognition burden to code readers.

and that "如果...那肯定就..." assertion looks pretty fragile or too implicit at the best, considering how it's phrased. That may be a result of your specific updating policy which is quite fragile to rely on in pretty low-level cpp code like this.

And that function name isMacOrMacSiliconDevice looks suspicious, I mean isn't the category of MacSilicon a part of Mac? It's kinda weird to or them.

And if it's not something wrong in playcover, please don't outsource your own work to the community.

@Coresi7

This comment was marked as outdated.

@TheMoonThatRises
Copy link
Member

It's very kindly of you to tell me that, however we are under investigating what we can do to make a hotfix workaround instead of letting player change the name of our product.

A hack I can come up with is basically to export the ipa with its CFDisplayName key modified, it's how PlayCover determines where to put the finalized app bundle. Since PlayCover deals with unsigned apps anyway, it's not like this would matter much

static func wrap(_ baseApp: BaseApp) throws -> URL {

I'll see if there is a feasible way that we can convert all existing app bundle to CFBundleName instead of CFDisplayName, it would reduce headache for titles like Honkai Impact 3rd CN as well

This is basically what my PR in #1100 does, except it turns them into the Bundle ID, which I believe should be more unique than CFBundleName.

@Coresi7

This comment was marked as outdated.

@Coresi7

This comment was marked as outdated.

@Coresi7

This comment was marked as outdated.

@Coresi7

This comment was marked as outdated.

@XuYicong
Copy link
Member

XuYicong commented Dec 8, 2023

Hello #1100 is merged. You may try it in nightly build tomorrow.

Edit: try nightly build 570

@Coresi7

This comment was marked as outdated.

@Coresi7

This comment was marked as outdated.

@James-Harden-13-R
Copy link

I still have graphical issues after I removed PlayTools, though the crash didn't happen anymore. I wonder what I can do to solve the problem. Thanks.

macOS 12.4.1

playcover: 3.0.0 beta 2

image

@byitSen
Copy link

byitSen commented Dec 28, 2023

所有需要麦克风权限的APP都无法正常使用语音,可能是系统本身问题。

@Lantern-r
Copy link

playcover: 3.0.0 beta 2
感谢您的帮助,在游戏中我遇见了两个小问题:

  1. 在选择海克斯界面,一旦进入锁定阶段便不会出现投票按钮。如果在此前没有进行投票,则连投票框(圆圈)都进不去。
  2. 在对局内无法打字,在大厅时可以。

@shycomet

This comment was marked as off-topic.

@shycomet
Copy link

@Coresi7 我使用了PlayCover2.0.5、3.0.0beta、3.0.0beta2、nightly542和nightly617这五个版本都尝试过,无一例外,全部报错。
iShot_2024-01-26_02 05 06
同时也有小伙伴反馈同样的问题。

@Coresi7

This comment was marked as outdated.

@akss5768
Copy link

@Coresi7 我使用了PlayCover2.0.5、3.0.0beta、3.0.0beta2、nightly542和nightly617这五个版本都尝试过,无一例外,全部报错。 iShot_2024-01-26_02 05 06 同时也有小伙伴反馈同样的问题。

我个人不再推荐使用playcover,建议尝试sideloadly I personally do not recommend using playcover anymore, now I recommend to run via sideloadly.

sideloady装的都是ipad模式 装备备战席 用起来不习惯 另外 似乎麦克风的问题仍然不能使用

@Coresi7

This comment was marked as outdated.

@Coresi7

This comment was marked as outdated.

@F1ySyn
Copy link

F1ySyn commented Feb 1, 2024

I believe what you have done for jkchess here is meaningful, as it indeed makes our experience on Mac much better.

However, I think since you plan to support keyboard operations for the game on Mac, it would be equally nice to bring official keyboard support to the iPad Pro with the Magic Keyboard, as the experience there is far more perfect.

At the same time, I wonder if it's possible to modify the frame rate limit by manually editing some files, because I actually use an M3 Max paired with a 240Hz screen (I need to clarify, this is not a mandatory requirement, just out of my personal curiosity).

I noticed in the boot.config file there is 'hdr-display-enabled=0' (but I have never seen this option in iOS and iPadOS, are you still testing the possibility of HDR?), and I also noticed in gameConfig there are some setting parameters: m_DisplayMode = 5, m_FramePerSecondSetting = 4, m_HighFrameRate = 0, m_HighResolution = 0, m_HDRBloom = 1, m_SSAO = 1, m_ColorGrading = 1, m_ContrastEnhance = 1, m_SoftLight = 1.

I also want to know if modifying these contents is safe, although it does not involve any game fairness.

In addition, I think Playcover is still meaningful, as sideloadly cannot modify resolution, and my experience under a 49-inch ultrawide screen is very poor. I know you might never bring official support to Mac, but honestly, I'm happy to see you striving for all this.

@Coresi7 Coresi7 changed the title [App Support]: I'm the dev of jkchess, what's wrong with our game and is there anything I can help? Abandoned, please delete or close this issue, thanks Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app-support Support for additional non gaming apps documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests