Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keys should be materialized if dict is changed in loop #66

Conversation

Pliner
Copy link
Contributor

@Pliner Pliner commented Aug 18, 2021

RuntimeError: dictionary changed size during iteration
  File "aiohttp/web.py", line 431, in _run_app
    await runner.cleanup()
  File "aiohttp/web_runner.py", line 294, in cleanup
    await self._cleanup_server()
  File "aiohttp/web_runner.py", line 381, in _cleanup_server
    await self._app.cleanup()
  File "aiohttp/web_app.py", line 430, in cleanup
    await self.on_cleanup.send(self)
  File "aiohttp/signals.py", line 34, in send
    await receiver(*args, **kwargs)  # type: ignore
  File "aiohttp/web_app.py", line 550, in _on_cleanup
    raise errors[0]
  File "aiohttp/web_app.py", line 541, in _on_cleanup
    await it.__anext__()
  File "app.py", line 695, in configure_http_client
    await resolver.close()
  File "aio_request/aiohttp.py", line 62, in close
    await self._task
  File "aio_request/aiohttp.py", line 72, in _resolve
    for key in self._results.keys():

@Pliner Pliner merged commit 368e252 into main Aug 18, 2021
@Pliner Pliner deleted the hotfix/keys-should-be-materialized-if-dict-is-modified-inside-loop branch August 18, 2021 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants