Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IA shouldn't merge/combine categories of different namespaces #1374

Closed
4 tasks done
Andre601 opened this issue Dec 23, 2021 · 3 comments
Closed
4 tasks done

IA shouldn't merge/combine categories of different namespaces #1374

Andre601 opened this issue Dec 23, 2021 · 3 comments
Labels
type: feature request Feature request. verdict: wont fix This will not be worked on because of various reasons.

Comments

@Andre601
Copy link
Collaborator

Andre601 commented Dec 23, 2021

Terms

  • I'm using the very latest version of ItemsAdder and its dependencies.
  • I already searched on this Github page to check if the same suggestion was already reported.
  • I already searched on the plugin wiki to know if the feature is already implemented.
  • I already searched on the Discord server to know if anyone already has a solution for this or if the feature was already suggested.

Discord tag (optional)

Andre_601#0601

Describe the solution you'd like

Right now does ItemsAdder merge categories from different namespaces, if those are using the same name for their categories in the category files.

If I for example have an item pack with namespace myitems and one with namespace otheritems and both have a yaml file containing all as a category, will ItemsAdder merge them together, even tho they have separate namespaces.

It makes sense to merge item categories if they share the same namespace, but having two separate namespaces merged is imo a wrong solution and not something most people want.

ItemsAdder should include the actual namespace used in the category file to create the category name.
As an example would all become myitems_all for the myitems namespace and otheritems_all in the otheritems namespace.

This should serve as a more than unique enough category id to not have some mix up unintentionally.
If people still want their pack to combine with another one could they just use the same namespace for the category itself...

Is your feature request related to a problem?

Yes. ItemsAdder merging categories together is unintentionally destroying the /ia GUI by having some categories not show up because they already got included in other categories, making the items pack appear broken or incomplete.

Pack creators may not be aware of this random quirk of IA and create common categories such as all or misc without realising that IA will merge their items into another category, if that items pack is handled first...

Describe alternatives you've considered

Alternative would be to now rewrite the category names, which may work if using the namespace_category format, but would also not guarantee that another items pack wouldn't also use this same name format...

Additional context

Here is a gif displaying the actual issue this "feature" causes.
gif

@Andre601 Andre601 added the type: feature request Feature request. label Dec 23, 2021
@LoneDev6 LoneDev6 added the priority: low This will be fixed in the next updates. label Jan 4, 2022
@Akiranya
Copy link

Akiranya commented Mar 25, 2022

I'm actually taking the advantage of this merging feature ... for me I added many furnitures pack from other authors and I added all of the furnitures into the "furnitures" category (created by IA). I think the merging feature is not that bad because it helps the server admins to manage all the stuff from different packs but from the "same category" (i.e. all furnitures packs, all food packs). Indeed, the /ia somehow can get messy but I think mostly importantly having the backend stuff cleaner is more important (backend stuff = the files in the /data folder). I duno what other people think about it.

@LoneDev6
Copy link
Collaborator

LoneDev6 commented Apr 5, 2023

I find it pointless, obviously people want to see every armor item in the armor category and not see 5 armor categories.
If your pack is a special pack which introduces "magical armors" you can call your category my_special_pack_magical_armors and set its display name to "Magical Armors".

@LoneDev6 LoneDev6 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 5, 2023
@LoneDev6 LoneDev6 added verdict: wont fix This will not be worked on because of various reasons. and removed priority: low This will be fixed in the next updates. labels Apr 5, 2023
@Andre601
Copy link
Collaborator Author

Andre601 commented Apr 5, 2023

That is your argument here.
It's not clear if people didn't want a change, so saying that they wouldn't like nor want it, without any proof is imo a bad practice to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request Feature request. verdict: wont fix This will not be worked on because of various reasons.
Projects
None yet
Development

No branches or pull requests

3 participants