Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree populators - tree type incorrect #1377

Closed
4 tasks done
lexingtonnn opened this issue Dec 24, 2021 · 3 comments
Closed
4 tasks done

tree populators - tree type incorrect #1377

lexingtonnn opened this issue Dec 24, 2021 · 3 comments
Labels
type: bug Something isn't working verdict: can't reproduce This issue cannot be reproduced by the developers
Milestone

Comments

@lexingtonnn
Copy link

lexingtonnn commented Dec 24, 2021

Terms

  • I'm using the very latest version of ItemsAdder and its dependencies.
  • I already searched on this Github page to check if the same issue was already reported.
  • I already searched on the plugin wiki to know if a solution is already known.
  • I already asked on the #💬ia-community-help channel on Discord to know if anyone already has a solution for the issue.

Discord tag (optional)

lexington#3236

What happened?

here's some Example code for Reference.

info:
namespace: lexington
trees_populators:
candycane_tree:
worlds:
- world
bottom_blocks:
- DIRT
- GRASS_BLOCK
- PODZOL
chance: 1
max_height: 250
min_height: 25
amount: 1
iterations: 1
tree_type: DARK_OAK

DARK_OAK acts as ACACIA currently.

leaves: lexington:candycane_tree_leaves
log: lexington:candycane_tree_log#1376 

Under "tree type:" certain trees are spawning incorrectly. for instance, the "ACACIA" try is spawning as a swamp tree. the DARK_OAK tree spawns as an acacia tree, and the REDWOOD spawns as a tall Jungle tree. I went through all the catagories, and only the BROWN_MUSHROOM and RED_MUSHROOM seemed to match correctly. Sorry I cant be my thorough in my explanation.

would put it as a very minor bug.

Steps to reproduce the issue

create a tree populator YML
then mess around with tree types.

Server version

This server is running CraftBukkit version 3360-Spigot-f65de01-c2e0bbd (MC 1.18.1) (implementing API version 1.18.1-R0.1-SNAPSHOT)

ItemsAdder Version

ItemsAdder version 2.5.1-beta4

ProtocolLib Version

ProtocolLib version 4.8.0-SHAPSHOT-b539

LoneLibs Version

LoneLibs version 1.0.16b

LightAPI Version (optional)

LightAPI version bukkit-5.1.0 (build SNAPSHOT)

LibsDisguises Version (optional)

LibsDisguises version 10.0.27

FULL server log

No response

Error (optional)

No response

ItemsAdder config.yml

No response

Problematic items yml configuration file (optional)

No response

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

No response

@lexingtonnn lexingtonnn added the type: bug Something isn't working label Dec 24, 2021
@LoneDev6
Copy link
Collaborator

LoneDev6 commented Jan 4, 2022

Strange, I'm using the Bukkit API code to spawn trees.

            case TREE:
            default:
                gen = TreeFeatures.OAK;
                break;
            case BIG_TREE:
                gen = TreeFeatures.FANCY_OAK;
                break;
            case REDWOOD:
                gen = TreeFeatures.SPRUCE;
                break;
            case TALL_REDWOOD:
                gen = TreeFeatures.PINE;
                break;
            case BIRCH:
                gen = TreeFeatures.BIRCH;
                break;
            case JUNGLE:
                gen = TreeFeatures.MEGA_JUNGLE_TREE;
                break;
            case SMALL_JUNGLE:
                gen = TreeFeatures.JUNGLE_TREE_NO_VINE;
                break;
            case COCOA_TREE:
                gen = TreeFeatures.JUNGLE_TREE;
                break;
            case JUNGLE_BUSH:
                gen = TreeFeatures.JUNGLE_BUSH;
                break;
            case RED_MUSHROOM:
                gen = TreeFeatures.HUGE_RED_MUSHROOM;
                break;
            case BROWN_MUSHROOM:
                gen = TreeFeatures.HUGE_BROWN_MUSHROOM;
                break;
            case SWAMP:
                gen = TreeFeatures.SWAMP_OAK;
                break;
            case ACACIA:
                gen = TreeFeatures.ACACIA;
                break;
            case DARK_OAK:
                gen = TreeFeatures.DARK_OAK;
                break;
            case MEGA_REDWOOD:
                gen = TreeFeatures.MEGA_PINE;
                break;
            case TALL_BIRCH:
                gen = TreeFeatures.SUPER_BIRCH_BEES_0002;
                break;
            case CRIMSON_FUNGUS:
                gen = TreeFeatures.CRIMSON_FUNGUS_PLANTED;
                break;
            case WARPED_FUNGUS:
                gen = TreeFeatures.WARPED_FUNGUS_PLANTED;
                break;
            case AZALEA:
                gen = TreeFeatures.AZALEA_TREE;

@LoneDev6
Copy link
Collaborator

LoneDev6 commented Jan 4, 2022

I'll try a thing in the next update which should fix your issue, but I'm not sure

@LoneDev6
Copy link
Collaborator

LoneDev6 commented Jan 4, 2022

@LoneDev6 LoneDev6 added this to the 2.5.2 milestone Jan 4, 2022
@LoneDev6 LoneDev6 closed this as completed Jan 4, 2022
@LoneDev6 LoneDev6 added the verdict: can't reproduce This issue cannot be reproduced by the developers label Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working verdict: can't reproduce This issue cannot be reproduced by the developers
Projects
None yet
Development

No branches or pull requests

2 participants