Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Internal Exception: io.netty.handler.codec.DecoderException #372

Closed
TheTrippyTree opened this issue Sep 2, 2020 · 7 comments
Closed
Labels
type: bug Something isn't working type: minecraft bug Bug that only Mojang can fix. Can be both client or server bug.

Comments

@TheTrippyTree
Copy link

Describe the bug
After adding some custom recipes to my server, I'm unable to join it.

When I try to join, this is as far as I get:

image

There are 513 custom recipes on this server and I'd like to add more. When I disable a bunch of the recipes, it works again after restarting the server. Is this a Minecraft limitation, or is it something that could be fixed?

The issue still occurs with all of the other plugins removed.

I don't believe this is a configuration issue as it appears to depend solely on the number of recipes. The problematic number of custom recipes appears to be 500.

499 custom recipes works as intended.

Enabling the recipes and reloading ItemsAdder while already on the server allows you to use the recipes, but as soon as you leave you are unable to join again.

To Reproduce
Steps to reproduce the behavior:

  1. Add 500+ custom recipes
  2. Run server
  3. Join server
  4. See error

Info (please complete the following information):

  • Server version: Spigot 1.16.2
  • Client version: Minecraft 1.16.2 with and without Optifine 1.16.2 G3
  • Plugin version: 2.0.43
@TheTrippyTree TheTrippyTree added the type: bug Something isn't working label Sep 2, 2020
@LoneDev6
Copy link
Collaborator

LoneDev6 commented Sep 2, 2020

Seems to be a Minecraft bug I think, seems the recipes book supports only 500 recipes: https://bugs.mojang.com/browse/MC-185901

Damn.. I think I can't do much about it, I'd have to stop sending the recipes packet completely on join, do you think it's a solution?

@LoneDev6 LoneDev6 added the type: minecraft bug Bug that only Mojang can fix. Can be both client or server bug. label Sep 2, 2020
@TheTrippyTree
Copy link
Author

Yeah. That’s what I figured unfortunately. Seems like Mojang is in no hurry to fix it either.

I did some additional testing with enabling the recipes while on already on the server. It turns out that only the first 500 recipes actually work. So while disabling the initial packets would allow players to join, this would only solve half of the problem. Or at least so I think. Might still be worth a shot?

The only other solution I could see working would be creating a custom crafting table that could potentially replace the default one. This way the plugin would be responsible for crafting. Could this work? I wonder if there’s some plugin that already does this. Might make the recipe book useless, but who ever used it anyway?

@LoneDev6
Copy link
Collaborator

LoneDev6 commented Sep 3, 2020

I think I found the issue and I can fix it. I already stop the server from sending custom recipes to the recipebook to
fix a duplication bug (which occured only with recipes that has renamed items in the ingredients) but I failed to stop another part of the packet which still contains data. Cleaning also this part of the packet should fix the issue.

I think that recipes book is quite useless at its stage, yes, but Mojang has definitely to fix this.

Please download the new update and let me know (I will publish it later)

@LoneDev6 LoneDev6 closed this as completed Sep 3, 2020
@TheTrippyTree
Copy link
Author

The fix was included in the 2.0.44 update, right?

I downloaded it and unfortunately I still cannot join after going from 499 recipes to 500.

@LoneDev6
Copy link
Collaborator

LoneDev6 commented Sep 4, 2020

I think the only solution is to remove the player .dat file using this tool: https://irath96.github.io/webNBT/

image
Right click recipes and delete, then save and start the server

You have to do this to each player. Or just delete the .dat files.. but they would lose last location, inventory...

@TheTrippyTree
Copy link
Author

I tried the tool and also deleting the world & player data but to no avail.

Sadly, this might truly be Mojang's problem to fix. :(

@LoneDev6
Copy link
Collaborator

I will publish an update this week which should fix the issue once for all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working type: minecraft bug Bug that only Mojang can fix. Can be both client or server bug.
Projects
None yet
Development

No branches or pull requests

2 participants