Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smithing Recipes were not updated to work correctly in 1.20+ #3741

Open
5 tasks done
jamydariels opened this issue Jun 16, 2024 · 1 comment
Open
5 tasks done

Smithing Recipes were not updated to work correctly in 1.20+ #3741

jamydariels opened this issue Jun 16, 2024 · 1 comment
Labels
status: need testing Issue needs to be tested to check if it's reproducible or not type: bug Something isn't working

Comments

@jamydariels
Copy link

Terms

  • I'm using the very latest version of ItemsAdder and its dependencies.
  • I am sure this is a bug and it is not caused by a misconfiguration or by another plugin.
  • I already searched on this Github page to check if the same issue was already reported.
  • I already searched on the plugin wiki to know if a solution is already known.
  • I already searched on the forums to check if anyone already has a solution for this.

Discord tag (optional)

megadose

What happened?

Relative to problems talked about in #3728 and #2815

You can't use smithing recipes at all in 1.20, since vanilla game forces you to put a trim on the smithing table if you want it to use.
Customcrafting allows to do smithing recipes without trims (but works terribly, breaks enchants etc..) might help to go see into that lol

If you have an idea of any other solution that could me a replacement solution for my problem, it can be appreciated aswell ^^

(note: here is what PSYCHEER answered me on discord yesterday

@megadose Hey! I just looked into my smithing table recipes and yes, it doesn't work with other items as diamond and netherite ingots/other gems
Idk why it worked before, maybe some of my mods was causing it to work to put custom items into smithing table and IA parsed it
)

I'm down to test early builds that corrects this if you need btw :)

Steps to reproduce the issue

Use a smithing recipe (without mods)
here's mine: (based on what you said in #524 and VSCode extension)

Server version

git-Purpur-2095 (MC: 1.20.2)

ItemsAdder Version

3.6.3-beta-14

ProtocolLib Version

5.2.1-SNAPSHOT-689

LoneLibs Version

1.0.54 (prolly 1.0.46 that is wrongly versioned as 54)

Full server log

No response

Error (optional)

No error, it's a problem that is client related

Problematic items yml configuration file (optional)

info:
  namespace: enderite
recipes:
  smithing:
    e_pickaxe:
      base: NETHERITE_PICKAXE
      addition: end_ingot
      result:
        item: enderite_pickaxe
        amount: 1
        move_attributes:
          enchants: true
          durability: true
          custom_model_data: false
          material: false
          other_nbt: true

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

No response

@jamydariels jamydariels added the type: bug Something isn't working label Jun 16, 2024
@PSYCHEER
Copy link

PSYCHEER commented Jun 16, 2024

It looks like IA doesnt register items to be applicable to put them into smithing table, bcz with items which are minecraft provided to be usable in there works with custom recipes.
EDIT: It is not forcing me to use trims templates, but I cant assign other items as vanilla mc uses and ingots/gems.
So I can only edit basic diamond to netherite or trim other armors.

@LoneDev6 LoneDev6 added the status: need testing Issue needs to be tested to check if it's reproducible or not label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: need testing Issue needs to be tested to check if it's reproducible or not type: bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

3 participants