Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the templates_dir warning #244

Closed
elegaanz opened this issue Sep 25, 2018 · 5 comments
Closed

Remove the templates_dir warning #244

elegaanz opened this issue Sep 25, 2018 · 5 comments
Labels
C: Enhancement New feature or request
Milestone

Comments

@elegaanz
Copy link
Member

At each launch, Rocket tells us:

Error: missing configuration key: 'template_dir'
    => Warning: Using default templates directory '"/home/baptiste/Projects/plume/templates"'

And many people think it is an error, and that something went wrong during the installation. We should either set it during the setup with the .env, or use a custom Rocket config from Rust code.

Plume version (and/or commit): 0.2.0

@elegaanz elegaanz added C: Enhancement New feature or request P: Low labels Sep 25, 2018
@igalic
Copy link
Contributor

igalic commented Sep 28, 2018

It feels like we should make the templates (and static) dir its own repository so people can fork them to make their own themes

@elegaanz
Copy link
Member Author

Actually, I would like to use askama for templates in the future, which would make it harder to put them in their own repository… However, theming with some CSS could be allowed in the future too.

Maybe we could still put them in another repository and "load" them with a git submodule (So if you want custom templates, you would clone Plume without the submodule, then clone in the template dir (or whatever) the repo of the theme we want…)

@igalic
Copy link
Contributor

igalic commented Sep 28, 2018

Actually, I would like to use askama for templates in the future, which would make it harder to put them in their own repository… However, theming with some CSS could be allowed in the future too.

can you elaborate on why it would make it harder?

@elegaanz
Copy link
Member Author

Templates are embedded in the binary with askama, they are not read from the file system when the app starts. So if you want to change them you should recompile the whole app (well actually it's true that's it is not more complicated, only a bit longer).

@elegaanz elegaanz added this to the Alpha 2 milestone Sep 29, 2018
@trinity-1686a
Copy link
Contributor

Fixed by #327

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants