Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support Foo's Client #15

Closed
liplum opened this issue Jul 12, 2022 · 4 comments
Closed

[Feature Request] Support Foo's Client #15

liplum opened this issue Jul 12, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@liplum
Copy link
Member

liplum commented Jul 12, 2022

Please support Foo's Client.
Kinda like this, in build.gradle.kts

mindustry {
    client {
        mindustry foo "v8" // or latest notation
        // or
        mindustry fooV7 "1105" // or latest notation
    }
}
@liplum liplum added the enhancement New feature or request label Jul 12, 2022
@liplum liplum added this to the Mgpp v1.1.1 milestone Jul 12, 2022
@liplum
Copy link
Member Author

liplum commented Jul 12, 2022

It's pretty troublesome because foo's client doesn't have a good convention for version management.
There is likely no stable way to retreive the jar file.

@liplum
Copy link
Member Author

liplum commented Jul 12, 2022

Since mgpp v1.1.1
Despite the unstable download convention of Foo's Client, this could work and you have got to configure it manually if it is changed.

  • For kotlin DSL
client {
    mindustry from GitHubLocation(
        user = "mindustry-antigrief",
        repo = "mindustry-client",
        version = "v8.0.0",
        release = "erekir-client.jar"
    )
}
  • For Groovy DSL
client {
    from GitHubLocation(
        user: 'mindustry-antigrief',
        repo: 'mindustry-client',
        version: 'v8.0.0',
        release: 'erekir-client.jar'
    )
}

@liplum liplum removed this from the Mgpp v1.1.1 milestone Jul 12, 2022
@liplum liplum self-assigned this Jul 12, 2022
@liplum
Copy link
Member Author

liplum commented Jul 12, 2022

I introuduced an easy way to add Foo's Client in 54f67c9

  • For kotlin DSL
client {
    mindustry from Foo(
        version = "v8.0.0",
        release = "erekir-client.jar"
    )
}
  • For Groovy DSL
client {
    from Foo(
        version: 'v8.0.0',
        release: 'erekir-client.jar'
    )
}

liplum added a commit that referenced this issue Jul 12, 2022
@liplum
Copy link
Member Author

liplum commented Feb 3, 2023

MGPP v2.0.0

Since mgpp v2.0.0, you can use this in build.gradle(.kts) to add a Foo's Client slot.

Kotlin DSL

runMindustry {
   addClient {
       fooClient(tag = "v8.0.0", file = "erekir-client.jar")
   }
}

Groovy DSL

runMindustry {
   addClient {
       fooClient tag: "v8.0.0", file: "erekir-client.jar"
   }
}

@liplum liplum closed this as completed Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant