Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRationalData is missing a lot of functionality #635

Open
kozross opened this issue Jan 16, 2024 · 3 comments
Open

PRationalData is missing a lot of functionality #635

kozross opened this issue Jan 16, 2024 · 3 comments
Labels
enhancement New feature or request low priority

Comments

@kozross
Copy link
Contributor

kozross commented Jan 16, 2024

Unlike its Scott-encoded cousin, we're missing a bunch of functionality, such as PShow, PNum, and quite a few besides. We should really add these.

There also doesn't seem to be any direct way to make one, other than pconstanting a PlutusTx Rational, which also seems weirdly deficient.

@kozross kozross added the enhancement New feature or request label Jan 16, 2024
@L-as
Copy link
Member

L-as commented Jan 18, 2024

it's because you shouldn't use it

@L-as
Copy link
Member

L-as commented Jan 18, 2024

You should probably convert it to PRational if you're using it, albeit there are times where you would want to use PRationalData. It's not a deliberate omission, but rather a deliberate deprioritisation.

@SeungheonOh
Copy link
Collaborator

I agree, hence it's low priority

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority
Projects
None yet
Development

No branches or pull requests

3 participants