This repository has been archived by the owner on Mar 9, 2021. It is now read-only.
Fix -Wundef warnings #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 24, 2015 12:36
Vanilla iOS projects define DEBUG to be 1 in the Debug build configuration, and don't define DEBUG at all in the Release build configuration. That means that if you make a release build DEBUG is implicitly 0, but if you turn on the -Wundef warning flag you'll get warnings about this implicit value. This change explicitly makes sure both that DEBUG is defined and that its value evaluates to true.
Was causing a warning with the -Wundef flag turned on when building the Mac project.
|
@maicki would love to get this merged, the Pocket SDK is causing warnings in our codebase without it. |
maicki
added a commit
that referenced
this pull request
Feb 27, 2015
Fix -Wundef warnings. Thanks for that!
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vanilla iOS projects define
DEBUGto be 1 in the Debug build configuration, and don't defineDEBUGat all in the Release build configuration. That means that if you make a release buildDEBUGis implicitly 0, but if you turn on the -Wundef warning flag you'll get warnings about this implicit value.This pull request explicitly makes sure both that
DEBUGis defined and that its value evaluates to true. It also fixes another warning related to using an iOS-only macro in the Mac project.This mirrors a change I made to our
FLAnimatedImageproject at Flipboard/FLAnimatedImage#66.