This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
feat(sentry): add request id (if present) as tag for correlation #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kschelonka
requested review from
cmharlow and
katerinachinnappan
and removed request for
a team
kschelonka
force-pushed
the
INFRA-1158/sentry-request-id
branch
from
ad50513
to
5e720ca
Compare
sri-kirsh
reviewed
Apr 3, 2023
| @@ -62,7 +64,12 @@ export const sentryPlugin: ApolloServerPlugin = { | |||
| // Log query and variables as extras (make sure to strip out sensitive data!) | |||
| scope.setExtra('query', ctx.request.query); | |||
| scope.setExtra('variables', JSON.stringify(ctx.request.variables)); | |||
|
|
|||
| // If present, add request id from request headers (passed down from gateway/router) | |||
| const requestId = | |||
sri-kirsh
approved these changes
Apr 3, 2023
kschelonka
changed the title
|
🎉 This PR is included in version 3.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Help correlate/trace requests to subgraphs to the original client request. Consumes a header passed down to subgraphs from the gateway (x-graph-request-id), and if present, sets a Sentry tag for tracing (following docs)
Depends on https://github.com/Pocket/client-api/pull/357 to actually have an effect.
INFRA-1158