Skip to content
This repository has been archived by the owner on May 24, 2018. It is now read-only.

Priority does not meet PocketMine definitions #79

Open
PEMapModder opened this issue Aug 19, 2015 · 0 comments
Open

Priority does not meet PocketMine definitions #79

PEMapModder opened this issue Aug 19, 2015 · 0 comments

Comments

@PEMapModder
Copy link
Contributor

According to PocketMine EventPriority class doc comment, plugins SHOULD NOT change events at MONITOR level. As a plugin, SimpleAuth should follow the definition for PocketMine event priorities.

According to RFC 2119:

This phrase, or the phrase "NOT RECOMMENDED" mean that
there may exist valid reasons in particular circumstances when the
particular behavior is acceptable or even useful, but the full
implications should be understood and the case carefully weighed
before implementing any behavior described with this label.

As there may be possibilities that other plugins would want to, maybe log commands at the MONITOR level assuming they are not going to be cancelled (which is the actual meaning of MONITOR), it is not suitable to cancel an event at that leve.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant