Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar displayed on all episode pages (instead of only on index pages) #345

Closed
Radiowiec opened this issue Nov 8, 2020 · 3 comments
Closed
Labels
Milestone

Comments

@Radiowiec
Copy link

System Information
Podcast Generator Version: 3.1
Webserver: Apache
PHP Version: 7.4

Podcast Generator Config

INSERT THE **CENSORED** CONFIG HERE

Expected behavior

No paging control (NAV tag) on single episode pages.

Actual behavior

All single episode pages display a navbar.

How to reproduce

Display any single episode page - a navbar is displayed at the bottom.

@Radiowiec Radiowiec added the Bug label Nov 8, 2020
@emilengler
Copy link
Collaborator

Can you provide a screenshot?

@Radiowiec
Copy link
Author

Radiowiec commented Nov 10, 2020

Of course. Look at the podcast at
https://www.download.blindiphone.pl/PodcastGenerator/index.php

indexpage

  • there's a NAV tag at the bottom there, which is correct. Look at a single episode page, e.g.

https://www.download.blindiphone.pl/PodcastGenerator/index.php?name=2020-08-06-prezentacja_launchera_square_home.mp3

  • there's also the NAV tag there (where it shouldn't).

singleepisode

I would suggest to solve it by enclosing proper section of the PodcastGenerator-3.1\PodcastGenerator\themes\default\index.php file with the following condition:
if (!isset($_GET[$link])) {
...
}

@emilengler
Copy link
Collaborator

Thanks for the report! I will fix it in the next release!

@emilengler emilengler added this to the 3.2 milestone Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants