Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakout dependency sets into extras, establish a better pattern for adapters with missing imports #35

Closed
timkpaine opened this issue Feb 7, 2024 · 0 comments
Labels
tag: internal Issues and PRs for maintainance of the project - not interesting to external users type: enhancement Issues and PRs related to improvements to existing features

Comments

@timkpaine
Copy link
Member

timkpaine commented Feb 7, 2024

We haven't yet decided whether we want to push for adapters to all be part of csp proper, or if we want/expect adapters to be maintained independently. Regardless, we currently have C++-based parquet and kafka adapters, python-based db, csv, perspective, websocket, symphony, and slack adapters, with plans for C++-based redis, andwebsocket adapters, so it seems likely that we will have a reliance on lots of python libraries.

We will want to establish a (better) pattern for optional dependency sets, at the very least moving optional dependencies to their own extras blocks in pyproject.toml, and having a more graceful handling at runtime when dependencies are missing.

@timkpaine timkpaine added type: enhancement Issues and PRs related to improvements to existing features tag: internal Issues and PRs for maintainance of the project - not interesting to external users labels Feb 7, 2024
This was referenced Feb 8, 2024
@Point72 Point72 locked and limited conversation to collaborators Mar 25, 2024
@timkpaine timkpaine converted this issue into discussion #165 Mar 25, 2024
@Point72 Point72 deleted a comment from trallard Mar 25, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
tag: internal Issues and PRs for maintainance of the project - not interesting to external users type: enhancement Issues and PRs related to improvements to existing features
Projects
None yet
Development

No branches or pull requests

1 participant