New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge request with OpenPCDet #31
Comments
@CSautier Sounds great. I really appreciate this great work. Could you please share with me your PR before you want to merge to PCDet? I might want to make some modifications to the readme if possible. The main maintainer of PCDet is my previous labmate so it could be better if I talk to him ahead of time. |
I added you as a collaborator on the fork at https://github.com/CSautier/OpenPCDet/tree/ONCE |
@CSautier Sounds good. I made some modifications to the document and have no other concerns. Feel free to submit this PR to OpenPCDet, and let me know if there are any problems. From previous feedback the results of CenterPoint are not quite stable, ranging from 58 to 60. It is mainly because the training set is quite small and different random seeds could lead to quite different results. I think it's ok and you can report your own reproduction results to OpenPCDet. |
Ok, thanks for the feedback. I have been able to reproduce similar results as in your article for PVRCNN, SECOND and PointRCNN. As I expected, CenterPoint seems to follow a different distribution, I added a warning in the README for now, and will suggest putting values of a new 8GPUS run later on. I am still running a model on PointPillars, and if it works normally, will put the PR to OpenPCDet in the next days. |
Hi, I would suggest you report your own reproduced results here https://github.com/CSautier/OpenPCDet/tree/ONCE#once-3d-object-detection-baselines, which would be more reasonable as people who use OpenPCDet can easily reproduce the results. To resolve the inconsistent performance of CenterPoint between reproduction and paper, we can add a shortcut to this repo for their reference and reproduction. |
Also, I'd like to know your reproduced results of CenterPoint. I noticed some config changes here https://github.com/CSautier/OpenPCDet/blob/812d2b8cac59accb88a1a0729f9f7857db3c70b5/tools/cfgs/once_models/centerpoint.yaml#L70. The loc_weight I set in this repo should be 0.25. Will that influence the performance? |
Hi, |
I am surprised you get a much higher performance with one GPU training. That might be because more training iterations lead to better performance. We should remove the words "*Results are not reproducible with this version of the code" if you didn't try 8-GPU training. If you tried that you can update your own result, which would be clearer. |
Actually, my experiments on both SECOND and PVRCNN show an improvement with a single GPU training of about 2 mAP points. |
I finished two training on 8 GPUs with the new code of centerpoint, with different values of loc_weight. loc_weight = 1.0 loc_weight = 0.25 |
Hi,
I've been working on a merge of your codebase with the official OpenPCDet from OpenMMLab for the supervised part. The purpose would be that OpenPCDet would support supervised training on ONCE directly.
I would like to make a PR of my merge on OpenPCDet when it's ready, but I will wait for your agreement on that. Also if you have specific requirements on License, citation or parts of the code I should not include, don't hesitate to tell me, and we can see with OpenMMLab what can be done.
The text was updated successfully, but these errors were encountered: