Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keep_best_iv should order by iv then cp #1464

Closed
achretien opened this issue Jul 28, 2016 · 1 comment
Closed

keep_best_iv should order by iv then cp #1464

achretien opened this issue Jul 28, 2016 · 1 comment

Comments

@achretien
Copy link
Contributor

Expected Behavior

If we have 3 pokemon of a type and wanted to keep the 2 best IV and two pokemon have the same low IV, we would like to keep the one with max CP

Actual Behavior

[20:25:39] Keep 2 best Slowpoke, based on iv
[20:25:39] Slowpoke [CP 274] [Potential 0.56]
[20:25:39] Slowpoke [CP 172] [Potential 0.51]
[20:25:39] Exchange 1 pokemon(s)
[20:25:39] Exchanging Slowpoke [CP 392] [Potential 0.51] for candy!

Steps to Reproduce

Farm pokemon and have some luck :)

Other Information

OS: OSX
Git Commit: (run 'git log -n 1 --pretty=format:"%H"' and paste it here)
34caa00
@achretien achretien mentioned this issue Jul 28, 2016
Merged
@achretien
Copy link
Contributor Author

Fixed by #1472

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@achretien