Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV] Forts info are not updated in location-*.json #2198

Closed
Gregwar opened this issue Aug 1, 2016 · 3 comments
Closed

[DEV] Forts info are not updated in location-*.json #2198

Gregwar opened this issue Aug 1, 2016 · 3 comments

Comments

@Gregwar
Copy link

Gregwar commented Aug 1, 2016

It appear that forts infos are not updated in location-*.json
When the file is created at startup forts are in it, but later the forts data disappear
(Note: I'm testing the cluster strategy)
EDIT: It seems that forts info are written only sometime, is that true/normal?

@SamuraiKal
Copy link
Contributor

SamuraiKal commented Aug 1, 2016

tl;dr This should have minimal to no impact on the website as long as the bot is working correctly. However, the bot is not currently working correctly because this is not merged yet: #2269

The long version:
This actually helped me find another larger issue where the fort data was getting lost entirely by the bot when the server returns no fort data. I fixed this in #2269 (It's still waiting for the pull request to be approved, but it should fix the issue where fort pathing randomly breaks.)

However, it does not fix the saving of the empty fort data to the location-*.json in the web directory, it only fixes the bot's internal location data.

Even so, it seems like the website updates the forts just fine as long as it picks up one of the fort updates from the bot (fort updates seem to happen when you first load the bot, spin a fort, or a lure has become active/inactive on a nearby fort).

@Gregwar
Copy link
Author

Gregwar commented Aug 1, 2016

OK
Is it because we ask the fort data too often?
It looks like I'm also being disconnected often, just like #2184

@SamuraiKal
Copy link
Contributor

I added a new comment to the issue you referenced. The "follow cluster" task seems to be referencing the bot's internal fort cache. When the bot loses it's fort cache, the "follow cluster" task no longer has a valid fort reference for the request to the server.

Once my pull is approved, it should fix that specific behavior. You could also grab the changes and apply them manually to your local branch. The only file changes that matter for this are in pokemongo_bot/init.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants