Some XP efficiency improvements #2889

douglascamata · 2016-08-07T18:12:46Z

All this code was based on PR #2491 (thx a lot, @matheussampaio).

Run tasks in a time based way

BaseTask now adds two helpers to every single task: _update_last_ran and _time_to_run. Both can be used in any task to ensure will only run from time to time and not in every single tick. Example:

def work(self):
    if not self._time_to_run():
        return False
    self._update_last_ran()

Then if the task config someone like this can be used to customise the time interval (in seconds):

{
    "type": "TransferPokemon",
    "config": {
        "run_interval": 60 
     }
}

Added option in SpinFort and MoveToFort to run even without inventory space (because RecycleItem may be run only after more time)

{
    "type": "SpinFort",
    "config": {
        "ignore_item_count": true
    }
},

Exp result:

I saw a bigger than 50% experience per hour increase in my bot. Everyone should see something similar unless in a bad place to bot or with poor configuration.

2016-08-07 19:59:34,083 [ cli] [INFO] Total XP Earned: 13540 Average: 66236.29/h

…inimum tick time of 5 seconds Tasks inheriting from BaseTask should use `self._update_last_ran` and `_time_to_run` if they want to implement the time based running. The config to set a custom timer is named `run_interval`.

this works good with the `run_interval` configuration added to TransferPokemon and RecycleItem

…e/xp-improvements

douglascamata · 2016-08-07T18:47:52Z

@TheSavior review, please.

chengchengmu · 2016-08-07T18:48:46Z

It was looping on Moving to fort and Arrived at fort, could you check this ?

016-08-07 20:36:09,640 [MoveToFort] [INFO] [moving_to_lured_fort] Moving towards pokestop Buste Hector Berlioz - 0.05km (attraction of lure 0.09km)
2016-08-07 20:36:16,854 [MoveToFort] [INFO] [arrived_at_fort] Arrived at fort.
2016-08-07 20:36:24,269 [MoveToFort] [INFO] [moving_to_lured_fort] Moving towards pokestop Buste Hector Berlioz - 0.05km (attraction of lure 0.08km)
2016-08-07 20:36:31,040 [MoveToFort] [INFO] [moving_to_lured_fort] Moving towards pokestop Buste Hector Berlioz - 0.04km (attraction of lure 0.07km)
2016-08-07 20:36:39,275 [MoveToFort] [INFO] [arrived_at_fort] Arrived at fort.
2016-08-07 20:36:46,580 [MoveToFort] [INFO] [moving_to_lured_fort] Moving towards pokestop Buste Hector Berlioz - 0.04km (attraction of lure 0.07km)
2016-08-07 20:36:54,809 [MoveToFort] [INFO] [arrived_at_fort] Arrived at fort.
2016-08-07 20:37:01,584 [MoveToFort] [INFO] [moving_to_lured_fort] Moving towards pokestop Buste Hector Berlioz - 0.04km (attraction of lure 0.07km)
2016-08-07 20:37:08,975 [MoveToFort] [INFO] [arrived_at_fort] Arrived at fort.
2016-08-07 20:37:16,196 [MoveToFort] [INFO] [moving_to_lured_fort] Moving towards pokestop Buste Hector Berlioz - 0.04km (attraction of lure 0.07km)
2016-08-07 20:37:23,364 [MoveToFort] [INFO] [arrived_at_fort] Arrived at fort.
2016-08-07 20:37:29,629 [MoveToFort] [INFO] [moving_to_lured_fort] Moving towards pokestop Buste Hector Berlioz - 0.04km (attraction of lure 0.07km)
2016-08-07 20:37:42,246 [MoveToFort] [INFO] [arrived_at_fort] Arrived at fort.

douglascamata · 2016-08-07T18:50:44Z

@menren your comment is not related to this PR and is a consequence of bad configuration. Please, go to the help channel in Slack to discuss about it. This is not the right place.

chengchengmu · 2016-08-07T18:51:50Z

I could be.

However it does never loop with dev branch's code. Just wondering if it could be a side effect of some new features

douglascamata · 2016-08-07T18:58:36Z

@menren what is your task list?

chengchengmu · 2016-08-07T19:02:09Z

I am using a configuration based on https://github.com/PokemonGoF/PokemonGo-Bot/blob/master/configs/config.json.example
except that I added the fields you mentionned and also added "ignore_item_count" in MoveToFort

Naiters · 2016-08-07T19:04:45Z

After applying your changes I got this error:

Traceback (most recent call last):
File "pokecli.py", line 41, in
from pokemongo_bot import PokemonGoBot, TreeConfigBuilder
File "/home/wojtek/PokemonGo-Bot/pokemongo_bot/init.py", line 18, in
import cell_workers
File "/home/wojtek/PokemonGo-Bot/pokemongo_bot/cell_workers/init.py", line 3, in
from catch_lured_pokemon import CatchLuredPokemon
File "/home/wojtek/PokemonGo-Bot/pokemongo_bot/cell_workers/catch_lured_pokemon.py", line 4, in
from pokemongo_bot.base_task import BaseTask
ImportError: No module named base_task

Any advice?

douglascamata · 2016-08-07T19:04:55Z

@menren that configuration is not good and is prone to this kind of error that you're experiencing.

douglascamata · 2016-08-07T19:05:42Z

@Naiters you're not applying the modifications correctly, probably. I was running the bot here for almost 1 hour and no errors.

chengchengmu · 2016-08-07T19:09:08Z

@douglascamata Which configuration are you using and is good ?

douglascamata · 2016-08-07T19:09:52Z

@menren I use my configuration and I'm very satisfied. As I said, this is not the place to discuss these things, please go to the proper channel in Slack for this discussion.

w0rd3r · 2016-08-07T20:08:54Z

@douglascamata Hello and thank you for this. I'm currently using this but have something like 45k/H. So I guess it's my config file that isn't good enough. Would you be kind enough to share yours ?

Thanks!

douglascamata · 2016-08-07T20:27:51Z

@w0rd3r it can be config, bad luck or not so good place to bot. Tell me if you saw the expected around 50% experience improvement.

My configuration isn't any fancy, I just bot in a very populated and pokestop dense town. This is not the place to discuss configs tho.

w0rd3r · 2016-08-07T20:30:18Z

I'm in Central Park since the beginning. Had more than 200k/hour with this #2491

Here is my config with your pull FYI :

{
"auth_service": "google",
"username": "",
"password": "",
"location": "40.774626,-73.972706",
"gmapkey": "",
"tasks": [
{
"type": "HandleSoftBan"
},
{
"type": "CollectLevelUpReward"
},
{
"type": "IncubateEggs",
"config": {
"longer_eggs_first": true
}
},
{
"type": "TransferPokemon"
},
{
"type": "EvolvePokemon",
"config": {
"evolve_all": "none",
"first_evolve_by": "cp",
"evolve_above_cp": 500,
"evolve_above_iv": 0.8,
"logic": "or",
"evolve_speed": 20,
"use_lucky_egg": false
}
},
{
"type": "RecycleItems",
"config": {
"item_filter": {
"Pokeball": { "keep" : 50 },
"Greatball": { "keep" : 70 },
"Ultraball": { "keep" : 80 },
"Potion": { "keep" : 0 },
"Super Potion": { "keep" : 0 },
"Hyper Potion": { "keep" : 0 },
"Revive": { "keep" : 0 },
"Max Revive": { "keep" : 0},
"Razz Berry": { "keep" : 50 }
}
}
},
{
"type": "CatchVisiblePokemon"
},
{
"type": "CatchLuredPokemon"
},
{
"type": "SpinFort"
},
{
"type": "MoveToFort",
"config": {
"lure_attraction": true,
"lure_max_distance": 2000
}
},
{
"type": "FollowSpiral",
"config": {
"diameter": 4,
"step_size": 70
}
}
],
"map_object_cache_time": 5,
"forts": {
"avoid_circles": true,
"max_circle_size": 50
},
"websocket_server": false,
"walk": 13.96,
"action_wait_min": 1,
"action_wait_max": 4,
"debug": false,
"test": false,
"health_record": true,
"location_cache": true,
"distance_unit": "km",
"reconnecting_timeout": 15,
"evolve_captured": "NONE",
"catch_randomize_reticle_factor": 1.0,
"catch_randomize_spin_factor": 1.0,
"catch": {
"any": {"catch_above_cp": 0, "catch_above_iv": 0, "logic": "or"},
"// Example of always catching Rattata:": {},
"// Rattata": { "always_catch" : true }
},
"release": {"any": {"keep_best_iv": 1, "keep_best_cp": 2},
"Tauros": {"keep_best_iv": 3},
"Snorlax": {"keep_best_iv": 10},
"Lapras": {"keep_best_iv": 10},
"Moltres": {"keep_best_iv": 10},
"Dragonite": {"keep_best_iv": 10},
"Flareon": {"keep_best_iv": 10},
"Gyarados": {"keep_best_iv": 10},
"Exeggutor": {"keep_best_iv": 10},
"Vaporeon": {"keep_best_iv": 10},
"Muk": {"keep_best_iv": 10},
"Mewtwo": {"keep_best_iv": 10},
"Mew": {"keep_best_iv": 10}

},
"vips" : {
"Any pokemon put here directly force to use Berry & Best Ball to capture, to secure the capture rate!": {},
"any": {"catch_above_cp": 1200, "catch_above_iv": 0.9, "logic": "or" },
"Lapras": {},
"Moltres": {},
"Zapdos": {},
"Articuno": {},

    "// S-Tier pokemons (if pokemon can be evolved into tier, list the representative)": {},
    "Mewtwo": {},
    "Dragonite": {},
    "Snorlax": {},
    "// Mew evolves to Mewtwo": {},
    "Mew": {},
    "Arcanine": {},
    "Vaporeon": {},
    "Gyarados": {},
    "Exeggutor": {},
    "Muk": {},
    "Weezing": {},
    "Flareon": {}

}

}

douglascamata · 2016-08-07T20:49:54Z

@w0rd3r I implemented exactly the same things. I think Niantic nerfed pokemon spawn and catch rate. Check without this PR how much you get and then check with the PR.

w0rd3r · 2016-08-07T20:55:17Z

Thanks, I'll see what happens. I went back to the classic pull cause I had better XP/H Than with your config unfortunately

Your pull : [INFO] Ran for 0:58:46
2016-08-07 22:33:28,923 [ cli] [INFO] Total XP Earned: 35660 Average: 36403.72/h

Dev : [INFO] Ran for 2:00:18
2016-08-07 21:26:58,602 [ cli] [INFO] Total XP Earned: 85175 Average: 42482.00/h

Philipp59 · 2016-08-07T21:10:10Z

@w0rd3r you have to use "run_interval": 60 and "ignore_item_count": true with this pull request and your config is very bad optimized for xp/h iam getting

2016-08-07 22:58:44,909 [       cli] [INFO] 
2016-08-07 22:58:44,909 [       cli] [INFO] Ran for 0:56:08
2016-08-07 22:58:44,909 [       cli] [INFO] Total XP Earned: 59795  Average: 63907.30/h

without this pull request
Iam pulling this and will give a feedback @douglascamata , sry for off topic here : ( (i know its not the place )

w0rd3r · 2016-08-07T21:12:08Z

@Philipp59 thanks, could you share a good config then?

AcorpBG · 2016-08-07T21:13:39Z

Run interval is working great for me. Expirience wise it vary alot depending on the area. If you have area with many stops that are lured or not. For me there was not very big exp increase but I'm using path so that is to be expected

TheSavior · 2016-08-07T21:18:25Z

pokemongo_bot/base_task.py

+        self._validate_work_exists()
+        self.logger = logging.getLogger(type(self).__name__)
+        self.last_ran = time.time()
+        self.run_interval = config.get('run_interval', 10)


It seems like this should default to None. It will always run every tick unless both the task utilizes _time_to_run, and the user configures how frequently..

@TheSavior the default value is 10 to make it work if the task does run in a time-based way. Otherwise if task is time-based and user don't provide run_interval every time he will see an error.

Unless the task was written such that it would delay only if it was configured with an interval. Otherwise it would run every tick

TheSavior · 2016-08-07T21:20:32Z

pokemongo_bot/cell_workers/catch_lured_pokemon.py

@@ -12,39 +13,52 @@ class CatchLuredPokemon(BaseTask):
    def work(self):
        lured_pokemon = self.get_lured_pokemon()
        if lured_pokemon:
-            self.catch_pokemon(lured_pokemon)
+            for pokemon in lured_pokemon:
+                self.catch_pokemon(pokemon)


What happens if your pokebag gets full while catching pokemon?

it just skips the catch, like it does already

w0rd3r · 2016-08-09T16:40:40Z

Mmmm that's weird. Put a screenshot here please

bibibkamal · 2016-08-09T16:49:02Z

w0rd3r · 2016-08-09T16:50:44Z

You have to be on the right folder cd /Users/****/PokemonGo-Bot before doing while sleep 10; do ./run.sh; done

So do it on the other terminal window that I see on the background. Do CTRL + C to abort, then while sleep 10; do ./run.sh; done

bibibkamal · 2016-08-09T17:03:37Z

@w0rd3r Now i get it! thanks bro!

douglascamata · 2016-08-09T17:07:44Z

This is outdated. We have similar effects now implemented in dev branch.

belinux · 2016-08-09T23:21:58Z

@douglascamata @w0rd3r I tried the dev branch for an hour and I didn't get even 40% of xp comparing to this branch.. I used the same config. can you share your config?
`"tasks": [
{
"type": "HandleSoftBan"
},
{
"type": "CollectLevelUpReward"
},
{
"type": "IncubateEggs",
"config": {
"longer_eggs_first": true
}
},
{
"type": "EvolvePokemon",
"config": {
"evolve_all": "none",
"first_evolve_by": "iv",
"evolve_above_cp": 0,
"evolve_above_iv": 0,
"logic": "or",
"evolve_speed": 2,
"use_lucky_egg": false
}
},
{
"type": "CatchVisiblePokemon"
},

  {
    "type": "CatchLuredPokemon"
  },
  {
    "type": "SpinFort",
    "config": {
        "ignore_item_count": true
     }
  },
  {
    "type": "RecycleItems",
    "config": {
      "run_interval": 300,
      "item_filter": {
        "Pokeball":       { "keep" : 125 },
        "Greatball":      { "keep" : 50 },
        "Ultraball":      { "keep" : 50 },
        "Potion":         { "keep" : 0 },
        "Super Potion":   { "keep" : 0 },
        "Hyper Potion":   { "keep" : 0 },
        "Max Potion":     { "keep" : 0 },
        "Revive":         { "keep" : 0 },
        "Max Revive":     { "keep" : 0 },
        "Razz Berry":     { "keep" : 50 }
      }
    }
  },
  {
    "type": "TransferPokemon",
    "config": {
        "run_interval": 300
     }
  },
  {
    "type": "MoveToFort",
    "config": {
        "lure_attraction": true,
        "lure_max_distance": 2000,
        "ignore_item_count": true
   }
  }
],
"map_object_cache_time": 5,
"forts": {
  "avoid_circles": true,
  "max_circle_size": 50
},
"websocket_server": false,
"walk": 80,
"action_wait_min": 0,
"action_wait_max": 0,
"debug": false,
"test": false,
"health_record": false,
"location_cache": false,
"distance_unit": "km",
"reconnecting_timeout": 3,
"evolve_captured": "Goldeen, Seel, Jigglypuff, Staryu, Poliwag, Slowpoke, Drowzee, Zubat, Rattata, Venonat, Spearow, Psyduck, Meowth, Bellsprout, Krabby, Pikachu, Ekans, Gloom, Paras, Kabuto, Eevee, Diglett, Sandshrew, Mankey, Magnemite, Shellder, Horsea, Krabby, Cubone, Gastly",
"catch_randomize_reticle_factor": 1.0,
"catch_randomize_spin_factor": 1.0,
"catch": {
  "any": {"catch_above_cp": 0, "catch_above_iv": 0, "logic": "or"}
},
"release": {
    "any": {
        "release_below_cp": 9, 
        "release_below_iv": 0.97, 
        "logic": "or"
    },
    "Caterpie": {
        "keep_best_iv": 45
    },
    "Weedle": {
        "keep_best_iv": 45
    },
    "Pidgey": {
        "keep_best_iv": 80
    },
    "Magikarp": {
        "keep_best_iv": 3
    },
    "Moltres": {
        "keep_best_iv": 3
    },
    "Zapdos": {
      "keep_best_iv": 3
    },
    "Articuno": {
      "keep_best_iv": 3
    },
    "Mewtwo": {
      "keep_best_iv": 3
    },
    "Dragonite": {
      "keep_best_iv": 5
    },
    "Gyarados": {
      "keep_best_iv": 5
    },
    "Lapras": {
      "keep_best_iv": 5
    },
    "Snorlax": {
      "keep_best_iv": 5
    }
},
"vips" : {
    "Bulbasaur": {},
    "Ivysaur": {},
    "Abra": {},
    "Gastly": {},
    "Charmander": {},
    "Charmeleon": {},
    "Squirtle": {},
    "Wartortle": {},
    "Pikachu": {},
    "Venusaur": {},
    "Charizard": {},
    "Blastoise": {},
    "Arcanine": {},
    "Vaporeon": {},
    "Flareon": {},
    "Chansey": {},
    "Gyarados": {},
    "Lapras": {},
    "Ditto": {},
    "Snorlax": {},
    "Dragonite": {},
    "Aerodactyl": {},
    "Kabutops": {},
    "Gengar": {},
    "Alakazam": {},
    "Raichu": {},
    "Omastar": {},
    "Electabuzz": {},
    "Magmar": {},
    "Scyther": {},
    "Nidoking": {},
    "Nidoqueen": {},
    "Moltres": {},
    "Zapdos": {},
    "Articuno": {},
    "Mewtwo": {},
    "Exeggutor": {},
    "Muk": {},
    "Weezing": {},
    "Mew": {}
}

`

douglascamata · 2016-08-09T23:39:51Z

@carlosbellino evolve pokemon task is very slow. Remove everything related to evolving pokemon.

N3W4L · 2016-08-10T12:07:43Z

Hi all,
Is there a way to install this easily? I had tons of errors after modifying files and some lines are missing or some of my files are completely different from your files. So not possible to modify lines as requested...

belinux · 2016-08-10T12:22:35Z

@N3W4L still using this instead of the dev branch.. got more XP per hour.. but, atm I`m setting the dev branch (kind of confusing yet) to use the snipe feature, so.. I think dev its better once everthing is set

N3W4L · 2016-08-10T12:45:38Z

@carlosbellino thanks for your answer, so I will wait.

w0rd3r · 2016-08-10T13:54:12Z

@douglascamata I still have way more HP/h with this config (switched to dev earlier to see)
Dev

This

All without lucky eggs.

douglascamata · 2016-08-10T14:03:53Z

@w0rd3r you need a long running time to be more accurate. See that dev code visited 82 stops but only caught 29 pokemon and evolve only 8.

In this branch you visit 76 stops, caught 42 pokemon and evolved 15. The number of catches and evolved makes a big difference.

It means your tests aren't accurate. I've been getting around 79~80k exp/h using dev (no lucky egg) and I tested running for 8 hours nonstop.

w0rd3r · 2016-08-10T14:09:10Z

@douglascamata fair enough, as long as we're both happy with our respective XP/h, I think we're good 😊

belinux · 2016-08-10T14:16:49Z

@douglascamata are you using a different tasks?? Please, share your config.js

douglascamata · 2016-08-10T14:21:17Z

@carlosbellino nothing fancy

"tasks": [
        {
          "type": "IncubateEggs",
          "config": {
            "longer_eggs_first": true
          }
        },
        {
          "type": "EvolvePokemon",
          "config": {
            "evolve_all": "Pidgey,Rattata,Zubat,Weedle,Drowzee,Spearow,Venonat,Caterpie,Krabby,Paras,Jigglypuff,Sandshrew,Vulpix,Meowth,Psyduck,Mankey,Tentacool,Ponyta,Slowpoke,Magnemite,Doduo,Seel,Voltorb,Horsea,Goldeen,Staryu,Ekans",
            "first_evolve_by": "iv",
            "evolve_above_cp": 0,
            "evolve_above_iv": 0,
            "logic": "or",
            "evolve_speed": 1,
            "use_lucky_egg": true,
            "run_interval": 60
          }
        },
        {
          "type": "TransferPokemon"
        },
        {
          "type": "RecycleItems",
          "config": {
            "run_interval": 60,
            "item_filter": {
              "Revive": { "keep" : 0 },
              "Razz Berry": { "keep" : 25 },
              "Pokeball": { "keep" : 50 },
              "Greatball": { "keep" : 80 },
              "Ultraball": { "keep" : 80 },
              "Potion": { "keep" : 0 },
              "Super Potion": { "keep" : 0 },
              "Hyper Potion": { "keep" : 0 },
              "Max Potion": { "keep" : 15 },
              "Max Revive": { "keep" : 15 }
            }
          }
        },
        {
          "type": "CatchVisiblePokemon"
        },
        {
          "type": "CatchLuredPokemon"
        },
        {
          "type": "SpinFort"
        },
        {
            "type": "MoveToFort",
            "config": {
                "lure_attraction": true,
                "lure_max_distance": 2000
            }
        },
        {
            "type": "SpinFort"
        },
        {
          "type": "CatchLuredPokemon"
        }

ulovehash · 2016-08-10T14:24:01Z

@douglascamata what about xp/h with your config?

icecubeice · 2016-08-10T14:24:47Z

2016-08-10 22:23:24,648 [PokemonCatchWorker] [INFO] [pokemon_appeared] A wild Kr abby appeared! [CP 129] [Potential 0.98] [S/A/D 14/15/15]
2016-08-10 22:23:26,835 [PokemonCatchWorker] [INFO] [vip_pokemon] This is a VIP pokemon. Catch!!!
2016-08-10 22:23:28,111 [PokemonCatchWorker] [INFO] [threw_berry] Threw a Razz Berry! Catch rate now: 93.43
2016-08-10 22:23:28,707 [ cli] [INFO]
2016-08-10 22:23:28,707 [ cli] [INFO] Ran for 0:00:26
2016-08-10 22:23:28,707 [ cli] [INFO] Total XP Earned: 50 Average: 6929.47/h
2016-08-10 22:23:28,709 [ cli] [INFO] Travelled 0.00km
2016-08-10 22:23:28,709 [ cli] [INFO] Visited 1 stops
2016-08-10 22:23:28,709 [ cli] [INFO] Encountered 1 pokemon, 0 caught, 0 released, 0 evolved, 0 never seen before
2016-08-10 22:23:28,709 [ cli] [INFO] Threw 0 pokeballs
2016-08-10 22:23:28,709 [ cli] [INFO] Earned 0 Stardust
2016-08-10 22:23:28,709 [ cli] [INFO]
2016-08-10 22:23:28,709 [ cli] [INFO] Highest CP Pokemon:
2016-08-10 22:23:28,709 [ cli] [INFO] Most Perfect Pokemon:
Traceback (most recent call last):
File "pokecli.py", line 503, in
main()
File "pokecli.py", line 89, in main
bot.tick()
File "C:\Users\Anthony\downloads\pokemongo-bot\pokemongo_bot__init__.py", line 450, in tick
if worker.work() == WorkerResult.RUNNING:
File "C:\Users\Anthony\downloads\pokemongo-bot\pokemongo_bot\cell_workers\catch_visible_pokemon.py", line 37, in work
self.catch_pokemon(pokemon)
File "C:\Users\Anthony\downloads\pokemongo-bot\pokemongo_bot\cell_workers\catch_visible_pokemon.py", line 63, in catch_pokemon
return_value = worker.work()
File "C:\Users\Anthony\downloads\pokemongo-bot\pokemongo_bot\cell_workers\pokemon_catch_worker.py", line 301, in work
'count_left': items_stock[pokeball]
File "C:\Users\Anthony\downloads\pokemongo-bot\pokemongo_bot\base_task.py", line 39, in emit_event
data=data
File "C:\Users\Anthony\downloads\pokemongo-bot\pokemongo_bot\event_manager.py", line 59, in emit
raise EventMalformedException("Event %s does not require parameter %s" % (event, k))
pokemongo_bot.event_manager.EventMalformedException: Event threw_pokeball does not require parameter pokeball

I get this error after changing the files according to yours

douglascamata · 2016-08-10T14:26:33Z

@icecubeice this PR is deprecated. Use it by your own risk, I do not support it anymore as we got similar improvements merged in dev already.

douglascamata · 2016-08-10T14:26:57Z

@ulovehash close to 90k exp/h at the place i'm using it.

ulovehash · 2016-08-10T14:28:50Z

@douglascamata would u share your geo for bot?

will post some stat screenshots to compare

douglascamata · 2016-08-10T14:33:35Z

@ulovehash you guys really want to have everything at hand, god's sake. Can't even find a nice place to bot. Compare it at the place you usually run, but do LONG tests rans of at least 2 hours, that should be enough. Also take into account the number of pokestops and lures placed.

icecubeice · 2016-08-10T14:33:43Z

@douglascamata ok, so to fix this will I just update my dev or?

douglascamata · 2016-08-10T14:34:14Z

@icecubeice checkout dev again and forget this PR.

belinux · 2016-08-10T14:41:21Z

@douglascamata Thank you for the config, almost the same im using..

N3W4L · 2016-08-10T16:08:27Z

@carlosbellino So you are all using this config with the original bot ? or did you implement anything to optimise it ?

belinux · 2016-08-10T16:22:49Z

I'm using that config it with this branch even it is deprecated.. I got better results removing evolve_captured as douglascamata mentioned..

N3W4L · 2016-08-10T16:36:22Z

Ok so I'm understanding nothing. I was thinking this whole PR was deprecated.
The Config file @douglascamata gave us isn't working with dev (original bot), is it normal ?

belinux · 2016-08-10T16:38:31Z

this PR it's deprecated.. I am using it on my own risk

ulovehash · 2016-08-11T10:57:28Z

Guys, mb u have any thoughts about why am i getting this message
"Possibly searching too often, take a rest."
after about 10-15 min after bot've been started

OS X
my config:

"tasks": [{
    "type": "HandleSoftBan"
}, {
    "type": "UpdateTitleStats",
    "config": {
        "min_interval": 60,
        "stats": ["uptime", "km_walked", "level_stats", "xp_earned", "stops_visited", "pokemon_caught", "pokemon_evolved"]
    }
}, {
    "type": "CollectLevelUpReward"
}, {
    "type": "IncubateEggs",
    "config": {
        "longer_eggs_first": true
    }
}, {
    "type": "RecycleItems",
    "config": {
        "run_interval": 60,
        "item_filter": {
            "Pokeball": {
                "keep": 80
            },
            "Greatball": {
                "keep": 60
            },
            "Ultraball": {
                "keep": 80
            },
            "Masterball": {
                "keep": 80
            },
            "Potion": {
                "keep": 0
            },
            "Super Potion": {
                "keep": 0
            },
            "Hyper Potion": {
                "keep": 0
            },
            "Max Potion": {
                "keep": 0
            },
            "Revive": {
                "keep": 0
            },
            "Max Revive": {
                "keep": 0
            },
            "Razz Berry": {
                "keep": 50
            }
        }
    }
}, {
    "type": "EvolvePokemon",
    "config": {
        "evolve_all": "Pidgey,Rattata,Zubat,Weedle,Drowzee,Spearow,Venonat,Caterpie,Krabby,Paras,Jigglypuff,Sandshrew,Vulpix,Meowth,Psyduck,Mankey,Tentacool,Ponyta,Slowpoke,Magnemite,Doduo,Seel,Voltorb,Horsea,Goldeen,Staryu,Ekans",
        "first_evolve_by": "cp",
        "evolve_above_cp": 0,
        "evolve_above_iv": 0,
        "logic": "or",
        "evolve_speed": 1,
        "use_lucky_egg": false,
        "run_interval": 180
    }
}, {
    "type": "TransferPokemon",
    "config": {
        "run_interval": 180
    }
}, {
    "type": "MoveToFort",
    "config": {
        "lure_attraction": true,
        "lure_max_distance": 2000,
        "ignore_item_count": true
    }
}, {
    "type": "SpinFort",
    "config": {
        "ignore_item_count": true
    }
}, {
    "type": "CatchVisiblePokemon"
}, {
    "type": "CatchLuredPokemon"
}],
"map_object_cache_time": 5,
"forts": {
    "avoid_circles": true,
    "max_circle_size": 500
},
"websocket_server": false,
"logging_color": true,
"walk": 80,
"action_wait_min": 0,
"action_wait_max": 1,
"debug": false,
"test": false,
"health_record": false,
"location_cache": false,
"distance_unit": "m",
"reconnecting_timeout": 15,
"evolve_captured": "NONE",
"catch_randomize_reticle_factor": 1.0,
"catch_randomize_spin_factor": 1.0,
"catch": {
    "any": {
        "always_catch": true
    }
},
"release": {
    "any": {
        "keep_best_iv": 1
    },
    "Moltres": {
        "keep_best_iv": 3
    },
    "Zapdos": {
        "keep_best_iv": 3
    },
    "Articuno": {
        "keep_best_iv": 3
    },
    "Mewtwo": {
        "keep_best_iv": 3
    },
    "Dragonite": {
        "keep_best_iv": 3
    },
    "Dratini": {
        "keep_best_iv": 3
    },
    "Dragonair": {
        "keep_best_iv": 3
    },
    "Snorlax": {
        "keep_best_iv": 3
    }
},
"vips": {
    "any": {
        "catch_above_cp": 1200,
        "catch_above_iv": 0.9,
        "logic": "or"
    },
    "Lapras": {},
    "Moltres": {},
    "Zapdos": {},
    "Articuno": {},
    "Mewtwo": {},
    "Dragonite": {},
    "Snorlax": {},
    "Mew": {},
    "Arcanine": {},
    "Vaporeon": {},
    "Gyarados": {},
    "Exeggutor": {},
    "Muk": {},
    "Weezing": {},
    "Flareon": {}
}

}

douglascamata added 6 commits August 7, 2016 17:49

catching every single pokemon nearby

204ad0e

catch lured pokemon in all forts nearby

c9b25d6

added config to ignore item count for Spin and MoveToFort

4f3a744

this works good with the `run_interval` configuration added to TransferPokemon and RecycleItem

spinning all pokestops in range

235f6bf

Merge branch 'dev' of github.com:PokemonGoF/PokemonGo-Bot into faetur…

ec83d2b

…e/xp-improvements

douglascamata added Approved Second Review Required labels Aug 7, 2016

TheSavior reviewed Aug 7, 2016
View reviewed changes

fixing loop in spin fort task

1fd60e7

TheSavior reviewed Aug 7, 2016
View reviewed changes

solderzzc deleted the faeture/xp-improvements branch August 10, 2016 17:20

Some XP efficiency improvements #2889

Some XP efficiency improvements #2889

Conversation

douglascamata commented Aug 7, 2016 • edited

Run tasks in a time based way

Added option in SpinFort and MoveToFort to run even without inventory space (because RecycleItem may be run only after more time)

Exp result:

douglascamata commented Aug 7, 2016

chengchengmu commented Aug 7, 2016 • edited

douglascamata commented Aug 7, 2016

chengchengmu commented Aug 7, 2016

douglascamata commented Aug 7, 2016

chengchengmu commented Aug 7, 2016

Naiters commented Aug 7, 2016

douglascamata commented Aug 7, 2016

douglascamata commented Aug 7, 2016

chengchengmu commented Aug 7, 2016

douglascamata commented Aug 7, 2016

w0rd3r commented Aug 7, 2016

douglascamata commented Aug 7, 2016 • edited

w0rd3r commented Aug 7, 2016

douglascamata commented Aug 7, 2016

w0rd3r commented Aug 7, 2016

Philipp59 commented Aug 7, 2016 • edited

w0rd3r commented Aug 7, 2016

AcorpBG commented Aug 7, 2016

TheSavior Aug 7, 2016

Choose a reason for hiding this comment

douglascamata Aug 7, 2016 • edited

Choose a reason for hiding this comment

TheSavior Aug 7, 2016

Choose a reason for hiding this comment

TheSavior Aug 7, 2016

Choose a reason for hiding this comment

douglascamata Aug 7, 2016

Choose a reason for hiding this comment

w0rd3r commented Aug 9, 2016

bibibkamal commented Aug 9, 2016

w0rd3r commented Aug 9, 2016 • edited

bibibkamal commented Aug 9, 2016

douglascamata commented Aug 9, 2016

belinux commented Aug 9, 2016 • edited

douglascamata commented Aug 9, 2016

N3W4L commented Aug 10, 2016

belinux commented Aug 10, 2016 • edited

N3W4L commented Aug 10, 2016

w0rd3r commented Aug 10, 2016

douglascamata commented Aug 10, 2016 • edited

w0rd3r commented Aug 10, 2016

belinux commented Aug 10, 2016

douglascamata commented Aug 10, 2016

ulovehash commented Aug 10, 2016

icecubeice commented Aug 10, 2016

douglascamata commented Aug 10, 2016

douglascamata commented Aug 10, 2016

ulovehash commented Aug 10, 2016

douglascamata commented Aug 10, 2016 • edited

icecubeice commented Aug 10, 2016

douglascamata commented Aug 10, 2016

belinux commented Aug 10, 2016

N3W4L commented Aug 10, 2016

belinux commented Aug 10, 2016

N3W4L commented Aug 10, 2016

belinux commented Aug 10, 2016 • edited

ulovehash commented Aug 11, 2016

douglascamata commented Aug 7, 2016 •

edited

chengchengmu commented Aug 7, 2016 •

edited

douglascamata commented Aug 7, 2016 •

edited

Philipp59 commented Aug 7, 2016 •

edited

douglascamata Aug 7, 2016 •

edited

w0rd3r commented Aug 9, 2016 •

edited

belinux commented Aug 9, 2016 •

edited

belinux commented Aug 10, 2016 •

edited

douglascamata commented Aug 10, 2016 •

edited

douglascamata commented Aug 10, 2016 •

edited

belinux commented Aug 10, 2016 •

edited