Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove protobuf installation via apt instead do everything via pip #3446

Closed
kinvaris opened this issue Aug 10, 2016 · 12 comments
Closed

Remove protobuf installation via apt instead do everything via pip #3446

kinvaris opened this issue Aug 10, 2016 · 12 comments

Comments

@kinvaris
Copy link

kinvaris commented Aug 10, 2016

Running on dev branch

Expected Behavior

Install protobuf 3.0

Actual Behavior

Installs protobuf 2.5

Steps to Reproduce

apt-get install python-protobuf

Other Information

OS: Linux jupiter 4.4.0-31-generic #50~14.04.1-Ubuntu SMP Wed Jul 13 01:07:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
See wiki: https://github.com/PokemonGoF/PokemonGo-Bot/wiki/Installation

@kinvaris kinvaris changed the title Remove protobuf installation via apt Remove protobuf installation via apt instead do everything via pip Aug 10, 2016
@Ph4i1ur3
Copy link

Why are you Installing protobuf via apt?

@Outpox
Copy link

Outpox commented Aug 10, 2016

I don't get the point of this issue, installing protobuf trough pip has already been suggested in several other issues.
@Ph4i1ur3 : Because that's what's suggested in the wiki.

@Ph4i1ur3
Copy link

That's really weird, as protobuf is part of requirements.txt

@ghost
Copy link

ghost commented Aug 10, 2016

The requirements.txt is being used during the 'pip install -r requirements.txt' command to install these dependencies using pip

@kinvaris
Copy link
Author

kinvaris commented Aug 10, 2016

@extink & @Outpox indeed, the reason of my title is just saying that needs to be removed from the wiki

@Outpox
Copy link

Outpox commented Aug 10, 2016

If you guys follow @kinvaris links in his original post, you'll see that he's talking about a specific wiki page where the linux installation steps for protobuf is apt-get install python-protobuf, which as we just stated isn't the correct way of doing it.

@Ph4i1ur3
Copy link

I would think the title could be changed to reflect the suggested change a little better

@Outpox
Copy link

Outpox commented Aug 10, 2016

Yeah and adding the "enhancement" label (if you can do it @kinvaris ) would be helpful as well.

@k4n30
Copy link
Contributor

k4n30 commented Aug 13, 2016

Is this fixed in #3781 ? If not I'd suggest making comments in there

@Outpox
Copy link

Outpox commented Aug 17, 2016

@k4n30 : It seems that according to this change it has not been fixed since it's still suggested to install protobuf using aptitude on Linux.

@k4n30
Copy link
Contributor

k4n30 commented Aug 17, 2016

@Outpox
Copy link

Outpox commented Aug 17, 2016

Good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants