-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove protobuf installation via apt instead do everything via pip #3446
Comments
Why are you Installing protobuf via apt? |
That's really weird, as protobuf is part of requirements.txt |
The requirements.txt is being used during the 'pip install -r requirements.txt' command to install these dependencies using pip |
If you guys follow @kinvaris links in his original post, you'll see that he's talking about a specific wiki page where the linux installation steps for protobuf is |
I would think the title could be changed to reflect the suggested change a little better |
Yeah and adding the "enhancement" label (if you can do it @kinvaris ) would be helpful as well. |
Is this fixed in #3781 ? If not I'd suggest making comments in there |
@k4n30 : It seems that according to this change it has not been fixed since it's still suggested to install protobuf using aptitude on Linux. |
@Outpox it's been updated since then https://github.com/PokemonGoF/PokemonGo-Bot/blob/dev/docs/manual_installation.md |
Good! |
Running on
dev
branchExpected Behavior
Install protobuf 3.0
Actual Behavior
Installs protobuf 2.5
Steps to Reproduce
Other Information
OS:
Linux jupiter 4.4.0-31-generic #50~14.04.1-Ubuntu SMP Wed Jul 13 01:07:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
See wiki: https://github.com/PokemonGoF/PokemonGo-Bot/wiki/Installation
The text was updated successfully, but these errors were encountered: