Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep_best_iv logic changed? #4480

Closed
Gurzeh opened this issue Aug 21, 2016 · 3 comments
Closed

keep_best_iv logic changed? #4480

Gurzeh opened this issue Aug 21, 2016 · 3 comments

Comments

@Gurzeh
Copy link
Contributor

Gurzeh commented Aug 21, 2016

related to #4459
Do you confirm that "JoeThePokemon": {"keep_best_iv": 1} only triggers transfer when min_free_slot is reached?

Your FULL config.json (remove your username, password, gmapkey and any other private info)

http://pastebin.com/XzFy46Tv

Other Information

OS: OSX Capitan
Branch: dev
Git Commit: 4f2e976
Python Version: Python 2.7.12

@Arlion
Copy link

Arlion commented Aug 21, 2016

I can confirm I am seeing the same thing

   "release": {
      "any": {"release_below_cp": 100, "release_below_iv": 0, "logic": "or"},
      "// Example of always releasing Rattata:": {},
      "// Rattata": {"always_release": true},
      "// Example of keeping 3 stronger (based on CP) Pidgey:": {},
      "// Pidgey": {"keep_best_cp": 3},
      "// Example of keeping 2 best (based on IV) Zubat:": {},
      "// Zubat": {"keep_best_iv": 2},
      "// Also, it is working with any": {},
      "any": {"keep_best_iv": 3},
      "// Example of keeping the 2 strongest (based on CP) and 3 best (based on IV) Zubat:": {},
      "// Zubat": {"keep_best_cp": 2, "keep_best_iv": 3},
          "// Example of custom order of static criterion": {},
          "// Zubat": {"keep_best_custom": "moveset.defense_perfection, hp_max", "amount":2}
    },

While I havn't reached max bag space yet, I'm getting close to it.
Dev Branch
Ubuntu 16.04
#4231

Additionally on startup it displays these pokemon which don't fit the above config.

2016-08-21 09:55:01,272 [PokemonGoBot] [INFO] #4 Charmander[1]: (CP 65, IV 0.67)
2016-08-21 09:55:01,273 [PokemonGoBot] [INFO] #10 Caterpie[1]: (CP 24, IV 0.29)
2016-08-21 09:55:01,273 [PokemonGoBot] [INFO] #16 Pidgey[1]: (CP 111, IV 0.56)
2016-08-21 09:55:01,273 [PokemonGoBot] [INFO] #17 Pidgeotto[1]: (CP 47, IV 0.56)
2016-08-21 09:55:01,273 [PokemonGoBot] [INFO] #21 Spearow[2]: (CP 148, IV 0.51) | (CP 45, IV 0.69)
2016-08-21 09:55:01,274 [PokemonGoBot] [INFO] #23 Ekans[2]: (CP 153, IV 0.4) | (CP 73, IV 0.51)
2016-08-21 09:55:01,274 [PokemonGoBot] [INFO] #24 Arbok[1]: (CP 501, IV 0.53)
2016-08-21 09:55:01,274 [PokemonGoBot] [INFO] #27 Sandshrew[1]: (CP 175, IV 0.51)
2016-08-21 09:55:01,274 [PokemonGoBot] [INFO] #29 Nidoran F[2]: (CP 33, IV 0.58) | (CP 32, IV 0.4)
2016-08-21 09:55:01,275 [PokemonGoBot] [INFO] #32 Nidoran M[1]: (CP 146, IV 0.62)
2016-08-21 09:55:01,275 [PokemonGoBot] [INFO] #35 Clefairy[1]: (CP 141, IV 0.44)
2016-08-21 09:55:01,275 [PokemonGoBot] [INFO] #37 Vulpix[1]: (CP 10, IV 0.71)
2016-08-21 09:55:01,275 [PokemonGoBot] [INFO] #41 Zubat[1]: (CP 10, IV 0.71)
2016-08-21 09:55:01,275 [PokemonGoBot] [INFO] #46 Paras[1]: (CP 11, IV 0.69)
2016-08-21 09:55:01,276 [PokemonGoBot] [INFO] #50 Diglett[2]: (CP 10, IV 0.64) | (CP 26, IV 0.47)
2016-08-21 09:55:01,276 [PokemonGoBot] [INFO] #52 Meowth[1]: (CP 31, IV 0.87)
2016-08-21 09:55:01,276 [PokemonGoBot] [INFO] #54 Psyduck[1]: (CP 152, IV 0.27)
2016-08-21 09:55:01,276 [PokemonGoBot] [INFO] #56 Mankey[1]: (CP 184, IV 0.73)
2016-08-21 09:55:01,277 [PokemonGoBot] [INFO] #58 Growlithe[3]: (CP 54, IV 0.58) | (CP 269, IV 0.47) | (CP 95, IV 0.82)
2016-08-21 09:55:01,277 [PokemonGoBot] [INFO] #59 Arcanine[1]: (CP 666, IV 0.93)
2016-08-21 09:55:01,277 [PokemonGoBot] [INFO] #60 Poliwag[1]: (CP 10, IV 0.51)
2016-08-21 09:55:01,277 [PokemonGoBot] [INFO] #63 Abra[1]: (CP 68, IV 0.47)
2016-08-21 09:55:01,277 [PokemonGoBot] [INFO] #66 Machop[1]: (CP 232, IV 0.78)
2016-08-21 09:55:01,278 [PokemonGoBot] [INFO] #67 Machoke[1]: (CP 182, IV 0.96)
2016-08-21 09:55:01,278 [PokemonGoBot] [INFO] #72 Tentacool[1]: (CP 62, IV 0.73)
2016-08-21 09:55:01,278 [PokemonGoBot] [INFO] #74 Geodude[1]: (CP 197, IV 0.62)
2016-08-21 09:55:01,278 [PokemonGoBot] [INFO] #75 Graveler[1]: (CP 19, IV 0.82)
2016-08-21 09:55:01,279 [PokemonGoBot] [INFO] #77 Ponyta[1]: (CP 20, IV 0.78)
2016-08-21 09:55:01,279 [PokemonGoBot] [INFO] #81 Magnemite[1]: (CP 84, IV 0.6)
2016-08-21 09:55:01,279 [PokemonGoBot] [INFO] #84 Doduo[1]: (CP 11, IV 0.76)
2016-08-21 09:55:01,279 [PokemonGoBot] [INFO] #90 Shellder[1]: (CP 173, IV 0.8)
2016-08-21 09:55:01,279 [PokemonGoBot] [INFO] #95 Onix[1]: (CP 10, IV 0.51)
2016-08-21 09:55:01,280 [PokemonGoBot] [INFO] #98 Krabby[1]: (CP 120, IV 0.71)
2016-08-21 09:55:01,280 [PokemonGoBot] [INFO] #104 Cubone[2]: (CP 43, IV 0.89) | (CP 157, IV 0.69)
2016-08-21 09:55:01,280 [PokemonGoBot] [INFO] #105 Marowak[1]: (CP 68, IV 0.53)
2016-08-21 09:55:01,280 [PokemonGoBot] [INFO] #111 Rhyhorn[3]: (CP 193, IV 0.93) | (CP 117, IV 0.73) | (CP 260, IV 0.84)
2016-08-21 09:55:01,281 [PokemonGoBot] [INFO] #118 Goldeen[2]: (CP 37, IV 0.33) | (CP 12, IV 0.62)
2016-08-21 09:55:01,281 [PokemonGoBot] [INFO] #128 Tauros[1]: (CP 183, IV 0.64)
2016-08-21 09:55:01,281 [PokemonGoBot] [INFO] #129 Magikarp[2]: (CP 41, IV 0.53) | (CP 10, IV 0.82)
2016-08-21 09:55:01,281 [PokemonGoBot] [INFO] #133 Eevee[1]: (CP 47, IV 0.91)
2016-08-21 09:55:01,282 [PokemonGoBot] [INFO] #140 Kabuto[1]: (CP 46, IV 0.8)

@AradeaTechno
Copy link

Never reached max slot for pokemon yet...but i think so ... Pokemon only will release when poke bag almost full....

Different trigger for latest update...

@k4n30 k4n30 closed this as completed Aug 22, 2016
@Gurzeh
Copy link
Contributor Author

Gurzeh commented Aug 22, 2016

@k4n30 you closed, means you acknowledge this answer? yes it does work and now I see the advantage: less API calls. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants