Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evolving all pokemon after update #4923

Closed
jnnck opened this issue Aug 30, 2016 · 6 comments
Closed

Evolving all pokemon after update #4923

jnnck opened this issue Aug 30, 2016 · 6 comments

Comments

@jnnck
Copy link

jnnck commented Aug 30, 2016

Expected Behavior

Only evolve pokemon in the evolve_list

Actual Behavior

Evolving all pokemon

Your FULL config.json (remove your username, password, gmapkey and any other private info)

http://pastebin.com/xZgs68YY

Output when issue occurred

[2016-08-30 10:20:09] [pokemon_evolved] Evolved Staryu [IV 0.82] [CP 514] [34 candies] [+1000 xp]

Steps to Reproduce

Other Information

OS: Mac osX
Branch: Dev
Git Commit: d7cf555
Python Version: Python 2.7.12

@mjmadsen
Copy link
Contributor

Hm. Must have messed up the logic somewhere. I'll take a gander in a bit.

@jnnck
Copy link
Author

jnnck commented Aug 30, 2016

Thanks, just disabled "evolvePokemon" for now. Thanks for all te great work!

@mjmadsen
Copy link
Contributor

Did you see it evolve pokemon that were in the list? If not I bet I filtered backwards.

@jnnck
Copy link
Author

jnnck commented Aug 30, 2016

Sorry, quickly stopped the bot since it allready evolved a Dragonair and Staryu that were cleary not on my list, to prevent further damage.

@mjmadsen
Copy link
Contributor

No problem. If you're willing, could you try #4925 - I'm at work and can't test right now.

I completely removed the processing of evolve_list when building the list of pokemon to evolve in a recent merge. My bad!

@jnnck
Copy link
Author

jnnck commented Aug 30, 2016

Can confirm this fix fixes the problem. Now evolving pokemon in evolve_list en nothing else.

[2016-08-30 11:25:21] [pokemon_evolved] Evolved Drowzee [IV 0.8] [CP 684] [5 candies] [+500 xp]
[2016-08-30 11:25:47] [pokemon_evolved] Evolved Pidgey [IV 0.24] [CP 361] [3 candies] [+500 xp]
[2016-08-30 11:26:18] [pokemon_evolved] Evolved Caterpie [IV 0.76] [CP 229] [20 candies] [+500 xp]
[2016-08-30 11:26:41] [pokemon_evolved] Evolved Caterpie [IV 0.47] [CP 222] [9 candies] [+500 xp]
[2016-08-30 11:27:02] [pokemon_appeared] A wild Jynx appeared! [CP 799] [NCP 0.47] [Potential 0.73] [A/D/S 15/3/15]

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants