Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polylinewalker is still drunk #5186

Closed
Brainarea opened this issue Sep 4, 2016 · 15 comments
Closed

Polylinewalker is still drunk #5186

Brainarea opened this issue Sep 4, 2016 · 15 comments

Comments

@Brainarea
Copy link

I noticed a few days ago that , on the DEV branch, the polylinewalker stopped working smoothly.
Even after today's modification, it still has the "drunk" type of walking.
poly

Any idea what's going on?

@maxprzemo
Copy link

In the file config.json remove lines
{
"type": "FollowSpiral",
"config": {
"enabled": true,
"diameter": 4,
"step_size": 70
}
}
I use the method "Follow Path" working as it should
zrzut ekranu z 2016-09-04 21 10 53

@Brainarea
Copy link
Author

Brainarea commented Sep 4, 2016

I removed followspiral and now polyline is working nicely. Aren't they supposed to work well together? It was the case last week.

@Brainarea Brainarea reopened this Sep 4, 2016
@th3w4y
Copy link
Contributor

th3w4y commented Sep 4, 2016

@Orchid666 no they are not of course...
they give conflicting directions....

@th3w4y
Copy link
Contributor

th3w4y commented Sep 4, 2016

Only one task should use the PolylineWalker if you want consistent results..

@Gobberwart
Copy link
Contributor

Gobberwart commented Sep 4, 2016

Told Polylinewalker to go home and sleep it off. Did that fix it?

@Brainarea
Copy link
Author

Well kind of, it puked all over the couch.

@mjmadsen
Copy link
Contributor

mjmadsen commented Sep 5, 2016

@th3w4y maybe we should disable it in the config by default (instead of deleting it).

@th3w4y
Copy link
Contributor

th3w4y commented Sep 7, 2016

@mjmadsen I do believe we are very close to that moment...

There are still some issues when multiple tasks call step walker..
We have so many follow BaseTask and each call their StepWalwer as they please!

@th3w4y
Copy link
Contributor

th3w4y commented Sep 7, 2016

@Orchid666 is this still a problem for you ?

@Brainarea
Copy link
Author

@th3w4y you mean polyline + spiral?

@th3w4y
Copy link
Contributor

th3w4y commented Sep 7, 2016

@Orchid666 i mean Polyline without spiral

(In my opinion Spiral should be deprecated!)

@Brainarea
Copy link
Author

Polyline without spiral always worked for me. Polyline with spiral used to work nicely then it stopped working so i wanted to bring that issue, but apparently it's something planned so i guess thats fine.

@Gobberwart
Copy link
Contributor

Currently using MoveToFort with polyline and it looks a lot less wobbly. Guess it sobered up a little.

@th3w4y
Copy link
Contributor

th3w4y commented Sep 8, 2016

@Gobberwart is only with spiral that would be messed up

@th3w4y
Copy link
Contributor

th3w4y commented Sep 11, 2016

#5367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants