Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"printedCards" or "officialCards" value request #61

Closed
daMoose52 opened this issue Jun 22, 2017 · 3 comments
Closed

"printedCards" or "officialCards" value request #61

daMoose52 opened this issue Jun 22, 2017 · 3 comments

Comments

@daMoose52
Copy link

Request for a feature that provides the printed or official number of cards to a set in addition to the total number of cards in a set; IE cards are numbed as "1/82" where 82 is the number of officially announced cards in the set, and then secret cards are printed as "83/82", "84/82" etc. At the moment, "totalCards" reflects the number of entries in the set, so if there are 84 total cards, 82+2 secret rares, "totalCards" will report 84 cards to the set. I personally identify my cards as "Name X/Y", so that I can rapidly ID where they are from without being as familiar with some of the expansion symbols (or guessing on sets that are silly close) so I can punch in "Gardevoir 54/98", information gleaned off the card, and land on the XY Ancient Origins Gardevoir.

@daMoose52
Copy link
Author

Attached, I've included a file as of Crimson Invasion; the totalCards column is from your DB, the other columns are some recommendations to help parse the sets out. Your totalCards appears off in a handful of places according to the numbers and breakdowns I found.
This includes: officialCards (what I was looking for), subsetCards (for sets with the RC sub groups, the Arceus set, etc), and secretCards, for the secret rares. "printedCards" then is the total of all of those.

pkmn_card_counts.txt

@adback03 adback03 added the v2 label Oct 7, 2020
@adback03 adback03 added this to the API v2 milestone Oct 7, 2020
@adback03
Copy link
Member

adback03 commented Oct 7, 2020

This will be making it into the initial release of the new api. A beta for v2 will be out in the next couple weeks.

@adback03
Copy link
Member

This has been solved with the release of V2. Separate printedTotal and totalCards (which includes secrets) now exist on the set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants