Missing McDonald and Trainer Kits

[felipewove]

Hi o/

Just noticed that is missing McDonald's collections and Trainers Kits.

Is this due to their collection name don't change?

If there is no problem, how can I help?

I'm using this as reference to create lists: https://assets.pokemon.com//assets/cms2/pdf/play-pokemon/rules/play-pokemon-deck-list-a4.pdf

[ProfessorOaksLab]

I think this is the full list of all cards/sets missing - Correct me if I'm wrong.

Trainer Kits

XY Trainer Kit
XY Trainer Kit: Bisharp & Wigglytuff
XY Trainer Kit: Latias & Latios
XY Trainer Kit: Pikachu Libre & Suicune
SM Trainer Kit: Alolan Sandslash & Alolan Ninetales
SM Trainer Kit: Lycanroc & Alolan Raichu
BW Trainer Kit
DP Trainer Kit
EX Trainer Kit
EX Trainer Kit 2
HS Trainer Kit

WCD

WCD 2016: Bebe Deck
WCD 2016: Black Dragon
WCD 2016: Magical Symphony
WCD 2016: Ninja Blitz
WCD 2017: Golisodor
WCD 2017: Ice Path FTW
WCD 2017: Infinite Force
WCD 2017: Samurai Sniper
WCD 2018: Buzzroc
WCD 2018: Dragones y Sombras
WCD 2018: Garbanette
WCD 2018: Victory Map
WCD 2019: Fire Box
WCD 2019: Mind Blown
WCD 2019: Perfection
WCD 2019: Pikarom Judge

Promos

Oversized Promos
SWSH Black Star Promos
"W" Promos
Best of Game Cards Promos
League Promos

Others

Winner Cards
XY Kalos Starter Set

Partnerships

Burger King DP Promos 2008
McDonald's Collection 2011
McDonald's Collection 2012
McDonald's Collection 2013
McDonald's Collection 2014
McDonald's Collection 2015
McDonald's Collection 2016
McDonald's Collection 2017
McDonald's Collection 2018 1 & 2
McDonald's Collection 2019

I'm building an app right now that uses this API, so I could probably take it upon myself to add these cards within the next couple of weeks.

[ProfessorOaksLab]

Where does the data for sets come from? Can't find it in the repository.

[Dillonzer]

@ProfessorOaksLab currently it's not in the Repo. @adback03 is working on cleaning it up and then uploading the blob.

[ProfessorOaksLab]

@Dillonzer cool :) And what are decks? They seem to be in the data, but not in the API?

[ProfessorOaksLab]

There is alot harder to find images for these sets in a scrapable way, or even with normal search. So if anyone could provide these images as hires (600x825 or higher) it would be great. These are the sets I've been going over so far and is missing images for:

Burger King 2008 DP Promos

Burger King 2008 DP Promos 6/130
Burger King 2008 DP Promos 9/130
Burger King 2008 DP Promos 35/130
Burger King 2008 DP Promos 49/130
Burger King 2008 DP Promos 52/123
Burger King 2008 DP Promos 56/130
Burger King 2008 DP Promos 76/130
Burger King 2008 DP Promos 93/130
Burger King 2008 DP Promos 94/123
Burger King 2008 DP Promos 98/130
Burger King 2008 DP Promos 103/130

BW Trainer Kit

Excadrill Half Deck 2/30
Excadrill Half Deck 4/30
Excadrill Half Deck 5/30
Excadrill Half Deck 6/30
Excadrill Half Deck 7/30
Excadrill Half Deck 9/30
Excadrill Half Deck 10/30
Excadrill Half Deck 13/30
Excadrill Half Deck 16/30
Excadrill Half Deck 20/30
Excadrill Half Deck 21/30
Excadrill Half Deck 23/30
Excadrill Half Deck 24/30

Zoroark Half Deck 1/30
Zoroark Half Deck 3/30
Zoroark Half Deck 5/30
Zoroark Half Deck 8/30
Zoroark Half Deck 10/30
Zoroark Half Deck 11/30
Zoroark Half Deck 13/30
Zoroark Half Deck 18/30
Zoroark Half Deck 20/30
Zoroark Half Deck 22/30
Zoroark Half Deck 24/30
Zoroark Half Deck 26/30
Zoroark Half Deck 29/30

[lfgcampos]

I would like to have them as well.

[MatiasOETamminen]

Is there any news on this? I'd be willing to contribute if possible.

[mattoni]

Also willing to help with this - any updates/progress?

[adback03]

A few of the mcdonalds sets have been added, still working on the others.

[MatiasOETamminen]

There's also this miniset: https://bulbapedia.bulbagarden.net/wiki/Pok%C3%A9mon_Futsal_Collection_(TCG)

[MatiasOETamminen]

There have been a lot of additions lately. I think we now only have the following English sets missing:

• the Trainer Kits mentioned in this issue
• Pokémon Futsal Collection EDIT: This has since been added.

The rest that are mentioned are either non-English (in the scope later on?) (e.g. MCD2013) or not sets but rather parts or variants of other sets, i.e. having the same set symbol as the parent set (e.g. the championship decks, W promos, League promos etc.), or at least I think of them in that way.

[jparanada]

MCD2022 images are here: https://cdn.malie.io/file/malie-io/art/scans/submissions/mcd2022.zip

The set is already on pkmncards: https://pkmncards.com/set/mcdonalds-collection-2022/ (this uses the same images as what's in the zip)

[WyldKnyght]

@ProfessorOaksLab
What needs to be done on this, there's a few updates, I'm willing to look for what's still outstanding?

[dylanlavon]

@WyldKnyght Would like to bump and mention that McDonald's Sets for '14, '15, '17, and '18 are all still missing images. Just seems to be an issue with them not being on pkmncards yet.