Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new attributes temporarily does not work (anymore) #1

Open
ChristophLeonhardt opened this issue Feb 6, 2023 · 1 comment
Open

Comments

@ChristophLeonhardt
Copy link
Collaborator

In previous applications of the package, setting the delete parameter of cwbtools::s_attribute_encode() seemed to effect whether the new attribute was added to the corpus permanently or temporarily. This does not seem to be the case (anymore).

LinkTools/R/LTDataset.R

Lines 515 to 519 in 2bd1924

if (isTRUE(add_temporarily)) {
delete_param <- TRUE
} else {
delete_param <- FALSE
}

I am not entirely sure why this would work in the first place. It is possible that it never did work. But it could be a useful option if attributes should only be added for a short period of time.

@ChristophLeonhardt
Copy link
Collaborator Author

To be discussed in issue #22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant