Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use()-Method | verbose parameter doesn't do much? #47

Closed
ChristophLeonhardt opened this issue Nov 7, 2018 · 3 comments
Closed

use()-Method | verbose parameter doesn't do much? #47

ChristophLeonhardt opened this issue Nov 7, 2018 · 3 comments

Comments

@ChristophLeonhardt
Copy link
Contributor

.message(sprintf("activating corpus: %s", corpus)) isn't affected by verbose = FALSE but probably should be given the parameter description.

@PolMine
Copy link
Collaborator

PolMine commented Nov 29, 2018

I'll take care of it.

@PolMine
Copy link
Collaborator

PolMine commented Dec 5, 2018

Thanks again for raising the issue. Solving this has been obvious and easy, we just need to pass the argument verbose into the auxiliary .message-function that produces the messages. The bug fix is included in the new development version of polmineR.

On this occasion, I took care that corpora that are activated are reported in capital letters. I had been thinking for a while that it is quite confusing that corpora show up in lowercase letters in the output message of the use()-function, but then you consistently need to use the uppercase version of the corpus name...

@PolMine PolMine closed this as completed Dec 5, 2018
@ChristophLeonhardt
Copy link
Contributor Author

The output in capital letters does makes a lot of sense indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant