Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shiny | Mail crashes when no mail is set #61

Closed
ChristophLeonhardt opened this issue Jan 21, 2019 · 2 comments
Closed

Shiny | Mail crashes when no mail is set #61

ChristophLeonhardt opened this issue Jan 21, 2019 · 2 comments

Comments

@ChristophLeonhardt
Copy link
Contributor

Clicking on the mail icon leads to a crash of the shiny app. R says: "Warning: Error in .mail: email is not set in session setting" which is logical but it would be nicer if the error is caught before the crash.

@ablaette
Copy link
Collaborator

Good point. I have just pushed a new polmineR version to the dev branch (v0.7.11.9029) that address this issue. You will now receive telling messages on why sending a result out by mail may have failed.

The "required authentication" message may be tricky to understand. For my organisation, the authentication requirement is fulfilled when I am logged into the network via VPN.

Please let me know whether things work now. Below the surface, I have reworked email-sending-operations and the messaging functionality of polmineR, so that messages you get in the shiny app can be implemented easily.

@PolMine
Copy link
Collaborator

PolMine commented Sep 30, 2019

Having reconsidered the solution I had implemented a few weeks ok, I think it adresses the issue you had raised: The shiny app will not crash if it is not possible to send out results; you get a warning message. So I close the issue.

@PolMine PolMine closed this as completed Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants