Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http_sd_configs to prometheus.yml in install.sh #501

Closed
wallezhang opened this issue Jul 1, 2022 · 1 comment · Fixed by #507
Closed

Add http_sd_configs to prometheus.yml in install.sh #501

wallezhang opened this issue Jul 1, 2022 · 1 comment · Fixed by #507
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers install installation or docker scripts

Comments

@wallezhang
Copy link
Contributor

What is the feature you want to add?
Add http_sd_configs to prometheus.yml file, so that the prometheus can fetch all metrics endpoints which client report.

Why do you want to add this feature?
Polaris support fetching client report metrics endpoints now, but http_sd_configs is not configured in prometheus.yml.

How to implement this feature?
Modify installPrometheus function in install.sh.

Additional context
Add any other context or screenshots about the feature request here.

@wallezhang wallezhang added the enhancement New feature or request label Jul 1, 2022
@chuntaojun chuntaojun added good first issue Good for newcomers install installation or docker scripts labels Jul 2, 2022
@wallezhang
Copy link
Contributor Author

Please assign to me. I'll try to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers install installation or docker scripts
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants