Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👨🏻‍💻 Improve documentation and test scripts #332

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Jun 20, 2024

What?

  • Add comments to migration functinos
  • Remove funding assets creation from chopsticks setup
  • Fix paseo to use polimec instead of politest

Copy link
Contributor Author

JuaniRios commented Jun 20, 2024

@JuaniRios JuaniRios force-pushed the 06-19-test_migration_with_zombienet branch from 6cd90ec to 76ff9b5 Compare June 20, 2024 11:55
@JuaniRios JuaniRios changed the base branch from main to 06-12-update_penpal June 20, 2024 11:55
@JuaniRios JuaniRios force-pushed the 06-19-test_migration_with_zombienet branch 2 times, most recently from a1942e9 to fda131d Compare June 21, 2024 10:09
@JuaniRios JuaniRios force-pushed the 06-19-test_migration_with_zombienet branch from fda131d to 2e9d7a9 Compare June 21, 2024 10:49
@JuaniRios JuaniRios force-pushed the 06-19-test_migration_with_zombienet branch from 2e9d7a9 to d81b2c6 Compare June 21, 2024 13:04
@JuaniRios JuaniRios force-pushed the 06-19-test_migration_with_zombienet branch from d81b2c6 to 4c9e7f3 Compare June 21, 2024 15:24
@JuaniRios JuaniRios force-pushed the 06-19-test_migration_with_zombienet branch from 4c9e7f3 to f2cdaa5 Compare June 21, 2024 16:01
@JuaniRios JuaniRios force-pushed the 06-19-test_migration_with_zombienet branch from f2cdaa5 to 883dece Compare June 24, 2024 08:53
@JuaniRios JuaniRios changed the title test migration with zombienet Improve documentation and test scripts Jun 24, 2024
@JuaniRios JuaniRios changed the title Improve documentation and test scripts 👨🏻‍💻 Improve documentation and test scripts Jun 24, 2024
@JuaniRios JuaniRios force-pushed the 06-19-test_migration_with_zombienet branch from 883dece to d49b0fe Compare June 24, 2024 09:14
@JuaniRios JuaniRios self-assigned this Jun 24, 2024
@JuaniRios JuaniRios force-pushed the 06-19-test_migration_with_zombienet branch 2 times, most recently from 6df07e2 to 6e3d04f Compare June 24, 2024 09:23
@JuaniRios JuaniRios marked this pull request as ready for review June 24, 2024 09:26
Base automatically changed from 06-12-update_penpal to main June 24, 2024 09:26
@JuaniRios JuaniRios force-pushed the 06-19-test_migration_with_zombienet branch 2 times, most recently from 0fa1904 to 18db06f Compare June 24, 2024 11:18
Copy link
Collaborator

@vstam1 vstam1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm except 1 comment

nodes/parachain/src/chain_spec/polimec_paseo.rs Outdated Show resolved Hide resolved
@JuaniRios JuaniRios force-pushed the 06-19-test_migration_with_zombienet branch from 18db06f to b8f5b65 Compare June 24, 2024 11:23
@JuaniRios JuaniRios mentioned this pull request Jun 24, 2024
Copy link
Contributor

@lrazovic lrazovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor adjustments are needed. These suggestions are merely recommendations, so please feel free to use different wording.

@JuaniRios JuaniRios merged commit 6a746b3 into main Jun 24, 2024
@JuaniRios JuaniRios deleted the 06-19-test_migration_with_zombienet branch June 24, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants