Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple fixes... #13

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Multiple fixes... #13

wants to merge 2 commits into from
+33 −29

Conversation

opsuu
Copy link

@opsuu opsuu commented Aug 24, 2021

  • Fixed init() printing out SDL Errors instead of TTF/IMG Errors.
  • Fixed init() printing out "TTF_init has failed. Error: " everytime TTF_Init initalized correctly.
  • Fixed crash on startup by changing char* to std::string on levelText and strokeText getter functions.
  • Fixed splashBg not being loaded.
    These are all the bugs I noticed while trying to compile on Linux with g++.

@erikyuzwa
Copy link

noice! 💯

darclander
darclander approved these changes Feb 28, 2022
View reviewed changes
Copy link

@darclander darclander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like char* vs string was an issue mentioned in #18 as well. The init function should work correctly with this fix. Rest looks like it should.

I have not compiled the code but looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darclander darclander darclander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@opsuu @erikyuzwa @darclander