feat: rename isOwned to isOwnedBy

src/api/entities/Portfolio/__tests__/index.ts

@@ -52,7 +52,7 @@ describe('Portfolio class', () => {
     });
   });
 
-  describe('method: isOwned', () => {
+  describe('method: isOwnedBy', () => {
     let did: string;
 
     beforeAll(() => {
@@ -63,13 +63,13 @@ describe('Portfolio class', () => {
     test('should return whether the current Identity is the Portfolio owner', async () => {
       let portfolio = new Portfolio({ did }, context);
 
-      let result = await portfolio.isOwned();
+      let result = await portfolio.isOwnedBy();
 
       expect(result).toBe(true);
 
       portfolio = new Portfolio({ did: 'notTheCurrentIdentity' }, context);
 
-      result = await portfolio.isOwned();
+      result = await portfolio.isOwnedBy({ identity: did });
 
       expect(result).toBe(false);
     });

src/api/entities/Portfolio/index.ts

@@ -4,7 +4,7 @@ import { Ticker } from 'polymesh-types/types';
 
 import { Entity, Identity, SecurityToken } from '~/api/entities';
 import { Context } from '~/base';
-import { balanceToBigNumber, portfolioIdToMeshPortfolioId, tickerToString } from '~/utils';
+import { balanceToBigNumber, getDid, portfolioIdToMeshPortfolioId, tickerToString } from '~/utils';
 
 import { PortfolioBalance } from './types';
 
@@ -50,15 +50,17 @@ export class Portfolio extends Entity<UniqueIdentifiers> {
   }
 
   /**
-   * Return whether the current Identity is the Portfolio owner
+   * Return whether an Identity is the Portfolio owner
+   *
+   * @param args.identity - defaults to the current Identity
    */
-  public async isOwned(): Promise<boolean> {
+  public async isOwnedBy(args?: { identity: string | Identity }): Promise<boolean> {
     const {
       owner: { did: ownerDid },
       context,
     } = this;
 
-    const { did } = await context.getCurrentIdentity();
+    const did = await getDid(args?.identity, context);
 
     return ownerDid === did;
   }

src/api/procedures/deletePortfolio.ts

@@ -34,7 +34,7 @@ export async function prepareDeletePortfolio(
   const rawPortfolioNumber = numberToU64(id, context);
 
   const [isOwned, rawPortfolioName, portfolioBalances] = await Promise.all([
-    numberedPortfolio.isOwned(),
+    numberedPortfolio.isOwnedBy(),
     queryPortfolio.portfolios(identityId, rawPortfolioNumber),
     numberedPortfolio.getTokenBalances(),
   ]);

src/api/procedures/renamePortfolio.ts

@@ -38,7 +38,7 @@ export async function prepareRenamePortfolio(
   const rawPortfolioNumber = numberToU64(id, context);
 
   const [isOwned, rawPortfolioName, rawPortfolios] = await Promise.all([
-    numberedPortfolio.isOwned(),
+    numberedPortfolio.isOwnedBy(),
     queryPortfolio.portfolios(identityId, rawPortfolioNumber),
     queryPortfolio.portfolios.entries(identityId),
   ]);

src/testUtils/mocks/entities.ts

@@ -171,7 +171,7 @@ let currentAccountGetTransactionHistoryStub: SinonStub;
 let tickerReservationDetailsStub: SinonStub;
 let venueDetailsStub: SinonStub;
 let instructionDetailsStub: SinonStub;
-let numberedPortfolioIsOwnedStub: SinonStub;
+let numberedPortfolioIsOwnedByStub: SinonStub;
 let numberedPortfolioGetTokenBalancesStub: SinonStub;
 
 const MockIdentityClass = class {
@@ -503,7 +503,7 @@ function initVenue(opts?: VenueOptions): void {
 function configureNumberedPortfolio(opts: NumberedPortfolioOptions): void {
   const numberedPortfolio = ({
     id: opts.id,
-    isOwned: numberedPortfolioIsOwnedStub.resolves(opts.isOwned),
+    isOwnedBy: numberedPortfolioIsOwnedByStub.resolves(opts.isOwned),
     getTokenBalances: numberedPortfolioGetTokenBalancesStub.resolves(opts.tokenBalances),
   } as unknown) as MockNumberedPortfolio;
 
@@ -519,7 +519,7 @@ function configureNumberedPortfolio(opts: NumberedPortfolioOptions): void {
  */
 function initNumberedPortfolio(opts?: NumberedPortfolioOptions): void {
   numberedPortfolioConstructorStub = sinon.stub();
-  numberedPortfolioIsOwnedStub = sinon.stub();
+  numberedPortfolioIsOwnedByStub = sinon.stub();
   numberedPortfolioGetTokenBalancesStub = sinon.stub();
 
   numberedPortfolioOptions = { ...defaultNumberedPortfolioOptions, ...opts };