Skip to content

Commit

Permalink
fix: transaction history portfolio amount
Browse files Browse the repository at this point in the history
  • Loading branch information
shuffledex committed Jan 21, 2021
1 parent b94632c commit 14a91b2
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 1 deletion.
11 changes: 11 additions & 0 deletions src/api/entities/Portfolio/__tests__/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -439,6 +439,17 @@ describe('Portfolio class', () => {
dsMockUtils.createApolloQueryStub(heartbeat(), true);
sinon.stub(utilsConversionModule, 'addressToKey').withArgs(account).returns(key);

const mockBalance1 = dsMockUtils.createMockBalance(amount1.toNumber());
const mockBalance2 = dsMockUtils.createMockBalance(amount2.toNumber());

const numberToBalanceStub = sinon.stub(utilsConversionModule, 'numberToBalance');
const balanceToBigNumberStub = sinon.stub(utilsConversionModule, 'balanceToBigNumber');

numberToBalanceStub.withArgs(amount1, context).returns(mockBalance1);
numberToBalanceStub.withArgs(amount2, context).returns(mockBalance2);
balanceToBigNumberStub.withArgs(mockBalance1).returns(amount1);
balanceToBigNumberStub.withArgs(mockBalance2).returns(amount2);

dsMockUtils.createApolloQueryStub(
settlements({
identityId: did,
Expand Down
3 changes: 2 additions & 1 deletion src/api/entities/Portfolio/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import {
identityIdToString,
keyToAddress,
middlewarePortfolioToPortfolio,
numberToBalance,
portfolioIdToMeshPortfolioId,
tickerToString,
} from '~/utils/conversion';
Expand Down Expand Up @@ -287,7 +288,7 @@ export class Portfolio extends Entity<UniqueIdentifiers> {
legs: settlementLegs.map(leg => {
return {
token: new SecurityToken({ ticker: leg!.ticker }, context),
amount: new BigNumber(leg!.amount),
amount: balanceToBigNumber(numberToBalance(new BigNumber(leg!.amount), context)),
direction: leg!.direction,
from: middlewarePortfolioToPortfolio(leg!.from, context),
to: middlewarePortfolioToPortfolio(leg!.to, context),
Expand Down

0 comments on commit 14a91b2

Please sign in to comment.