fix: improve boolToBoolean method & test

PolymeshAssociation · Mar 12, 2020 · a77f6b8 · a77f6b8
1 parent 591839e
commit a77f6b8
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/src/testUtils/mocks/PolkadotMockFactory.ts b/src/testUtils/mocks/PolkadotMockFactory.ts
@@ -664,8 +664,8 @@ export const createMockTokenName = (name?: string): TokenName =>
 export const createMockBool = (value?: boolean): bool =>
   createMockCodec(
     {
-      isTrue: () => value,
-      isFalse: () => !value,
+      isTrue: value,
+      isFalse: !value,
       valueOf: () => value,
     },
     !value

diff --git a/src/utils/__tests__/index.ts b/src/utils/__tests__/index.ts
@@ -1,4 +1,3 @@
-import { bool } from '@polymathnetwork/polkadot/types';
 import * as createTypeModule from '@polymathnetwork/polkadot/types/create/createType';
 import {
   Balance,
@@ -13,7 +12,7 @@ import sinon, { SinonStub } from 'sinon';
 import { ImportMock } from 'ts-mock-imports';
 
 import { PostTransactionValue } from '~/base';
-import { PolkadotMockFactory } from '~/testUtils/mocks';
+import { createMockBool, PolkadotMockFactory } from '~/testUtils/mocks';
 
 import {
   balanceToBigNumber,
@@ -234,9 +233,7 @@ describe('tokenNameToString', () => {
 describe('boolToBoolean', () => {
   test('boolToBoolean should convert a bool object to a boolean', () => {
     const fakeResult = true;
-    const mockBool = ({
-      valueOf: sinon.stub().returns(fakeResult),
-    } as unknown) as bool;
+    const mockBool = createMockBool(fakeResult);
 
     const result = boolToBoolean(mockBool);
     expect(result).toEqual(fakeResult);

diff --git a/src/utils/index.ts b/src/utils/index.ts
@@ -78,7 +78,7 @@ export function tokenNameToString(name: TokenName): string {
  * @hidden
  */
 export function boolToBoolean(value: bool): boolean {
-  return value.valueOf();
+  return value.isTrue;
 }
 
 /**