feat: add PortfolioCustody and AddMultiSigSigner as AuthorizationType

PolymeshAssociation · Oct 15, 2020 · c1a704e · c1a704e
1 parent 86306ed
commit c1a704e
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 9 deletions.
diff --git a/src/testUtils/mocks/dataSources.ts b/src/testUtils/mocks/dataSources.ts
@@ -1537,10 +1537,11 @@ export const createMockAuthorizationData = (
     | { AttestPrimaryKeyRotation: IdentityId }
     | { RotatePrimaryKey: IdentityId }
     | { TransferTicker: Ticker }
-    | 'AddMultiSigSigner'
+    | { AddMultiSigSigner: AccountId }
     | { TransferAssetOwnership: Ticker }
     | { JoinIdentity: Permission[] }
     | { TransferPrimaryIssuanceAgent: Ticker }
+    | { PortfolioCustody: PortfolioId }
     | { custom: Bytes }
     | 'NoData'
 ): AuthorizationData => {

diff --git a/src/types/index.ts b/src/types/index.ts
@@ -177,6 +177,7 @@ export enum AuthorizationType {
   TransferAssetOwnership = 'TransferAssetOwnership',
   TransferPrimaryIssuanceAgent = 'TransferPrimaryIssuanceAgent',
   JoinIdentity = 'JoinIdentity',
+  PortfolioCustody = 'PortfolioCustody',
   Custom = 'Custom',
   NoData = 'NoData',
 }
@@ -185,15 +186,10 @@ export enum AuthorizationType {
  * Authorization request data corresponding to type
  */
 export type Authorization =
-  | { type: AuthorizationType.NoData | AuthorizationType.AddMultiSigSigner }
+  | { type: AuthorizationType.NoData }
   | { type: AuthorizationType.JoinIdentity; value: Permission[] }
   | {
-      type: Exclude<
-        AuthorizationType,
-        | AuthorizationType.NoData
-        | AuthorizationType.AddMultiSigSigner
-        | AuthorizationType.JoinIdentity
-      >;
+      type: Exclude<AuthorizationType, AuthorizationType.NoData | AuthorizationType.JoinIdentity>;
       value: string;
     };
 

diff --git a/src/utils/__tests__/index.ts b/src/utils/__tests__/index.ts
@@ -1645,8 +1645,20 @@ describe('authorizationToAuthorizationData and authorizationDataToAuthorization'
 
     fakeResult = {
       type: AuthorizationType.AddMultiSigSigner,
+      value: 'someAccount',
     };
-    authorizationData = dsMockUtils.createMockAuthorizationData('AddMultiSigSigner');
+    authorizationData = dsMockUtils.createMockAuthorizationData({
+      AddMultiSigSigner: dsMockUtils.createMockAccountId(fakeResult.value),
+    });
+
+    // todo
+    fakeResult = {
+      type: AuthorizationType.PortfolioCustody,
+      value: '',
+    };
+    authorizationData = dsMockUtils.createMockAuthorizationData({
+      PortfolioCustody: dsMockUtils.createMock(fakeResult.value),
+    });
 
     result = authorizationDataToAuthorization(authorizationData);
     expect(result).toEqual(fakeResult);

diff --git a/src/utils/index.ts b/src/utils/index.ts
@@ -465,6 +465,7 @@ export function authorizationDataToAuthorization(auth: AuthorizationData): Autho
   if (auth.isAddMultiSigSigner) {
     return {
       type: AuthorizationType.AddMultiSigSigner,
+      value: accountIdToString(auth.asAddMultiSigSigner),
     };
   }
 
@@ -475,6 +476,14 @@ export function authorizationDataToAuthorization(auth: AuthorizationData): Autho
     };
   }
 
+  // todo
+  if (auth.isPortfolioCustody) {
+    return {
+      type: AuthorizationType.PortfolioCustody,
+      value: portfolioidtoportfolio,
+    };
+  }
+
   if (auth.isJoinIdentity) {
     return {
       type: AuthorizationType.JoinIdentity,