feat: make all claim types default

When adding a default trusted claim issuer, if trustedFor is undefined, it is interpreted as "all
claim types"

BREAKING CHANGE: - `null` is no longer an accepted value for `trustedFor` in `TrustedClaimIssuer`.
That behavior is replaced by `undefined`

src/api/entities/DefaultTrustedClaimIssuer.ts

@@ -13,7 +13,7 @@ export interface UniqueIdentifiers {
 }
 
 export interface Params {
-  trustedFor: ClaimType[] | null;
+  trustedFor?: ClaimType[];
 }
 
 /**
@@ -36,9 +36,9 @@ export class DefaultTrustedClaimIssuer extends Entity<UniqueIdentifiers> {
   public identity: Identity;
 
   /**
-   * claim types for which this Claim Issuer is trusted. A null value means that the issuer is trusted for all claim types
+   * claim types for which this Claim Issuer is trusted. An undefined value means that the issuer is trusted for all claim types
    */
-  public trustedFor: ClaimType[] | null;
+  public trustedFor?: ClaimType[];
 
   /**
    * ticker of the Security Token

src/api/entities/SecurityToken/Compliance/TrustedClaimIssuers.ts

@@ -100,10 +100,7 @@ export class TrustedClaimIssuers extends Namespace<SecurityToken> {
     const assembleResult = (issuers: TrustedIssuer[]): DefaultTrustedClaimIssuer[] =>
       issuers.map(
         ({ issuer }) =>
-          new DefaultTrustedClaimIssuer(
-            { did: identityIdToString(issuer), ticker, trustedFor: null },
-            context
-          )
+          new DefaultTrustedClaimIssuer({ did: identityIdToString(issuer), ticker }, context)
       );
 
     if (callback) {

src/api/entities/SecurityToken/Compliance/__tests__/TrustedClaimIssuers.ts

@@ -51,8 +51,8 @@ describe('TrustedClaimIssuers class', () => {
 
       const args: ModifyTokenTrustedClaimIssuersAddSetParams = {
         claimIssuers: [
-          { identity: entityMockUtils.getIdentityInstance({ did: 'someDid' }), trustedFor: null },
-          { identity: entityMockUtils.getIdentityInstance({ did: 'otherDid' }), trustedFor: null },
+          { identity: entityMockUtils.getIdentityInstance({ did: 'someDid' }) },
+          { identity: entityMockUtils.getIdentityInstance({ did: 'otherDid' }) },
         ],
       };
 
@@ -86,8 +86,8 @@ describe('TrustedClaimIssuers class', () => {
 
       const args: ModifyTokenTrustedClaimIssuersAddSetParams = {
         claimIssuers: [
-          { identity: entityMockUtils.getIdentityInstance({ did: 'someDid' }), trustedFor: null },
-          { identity: entityMockUtils.getIdentityInstance({ did: 'otherDid' }), trustedFor: null },
+          { identity: entityMockUtils.getIdentityInstance({ did: 'someDid' }) },
+          { identity: entityMockUtils.getIdentityInstance({ did: 'otherDid' }) },
         ],
       };
 
@@ -168,9 +168,7 @@ describe('TrustedClaimIssuers class', () => {
       claimIssuers = [];
 
       expectedDids.forEach(did => {
-        expectedTrustedClaimIssuers.push(
-          new DefaultTrustedClaimIssuer({ did, ticker, trustedFor: null }, context)
-        );
+        expectedTrustedClaimIssuers.push(new DefaultTrustedClaimIssuer({ did, ticker }, context));
         claimIssuers.push(
           dsMockUtils.createMockTrustedIssuer({
             issuer: dsMockUtils.createMockIdentityId(did),

src/api/entities/__tests__/DefaultTrustedClaimIssuer.ts

@@ -35,10 +35,7 @@ describe('DefaultTrustedClaimIssuer class', () => {
       const did = 'someDid';
       const ticker = 'SOMETICKER';
       const identity = new Identity({ did }, context);
-      const trustedClaimIssuer = new DefaultTrustedClaimIssuer(
-        { did, ticker, trustedFor: null },
-        context
-      );
+      const trustedClaimIssuer = new DefaultTrustedClaimIssuer({ did, ticker }, context);
 
       expect(trustedClaimIssuer.ticker).toBe(ticker);
       expect(trustedClaimIssuer.identity).toEqual(identity);
@@ -71,10 +68,7 @@ describe('DefaultTrustedClaimIssuer class', () => {
       const blockDate = new Date('4/14/2020');
       const eventIdx = 1;
       const fakeResult = { blockNumber, blockDate, eventIndex: eventIdx };
-      const trustedClaimIssuer = new DefaultTrustedClaimIssuer(
-        { did, ticker, trustedFor: null },
-        context
-      );
+      const trustedClaimIssuer = new DefaultTrustedClaimIssuer({ did, ticker }, context);
 
       dsMockUtils.createApolloQueryStub(eventByIndexedArgs(variables), {
         /* eslint-disable @typescript-eslint/camelcase */
@@ -92,10 +86,7 @@ describe('DefaultTrustedClaimIssuer class', () => {
     });
 
     test('should return null if the query result is empty', async () => {
-      const trustedClaimIssuer = new DefaultTrustedClaimIssuer(
-        { did, ticker, trustedFor: null },
-        context
-      );
+      const trustedClaimIssuer = new DefaultTrustedClaimIssuer({ did, ticker }, context);
 
       dsMockUtils.createApolloQueryStub(eventByIndexedArgs(variables), {});
       const result = await trustedClaimIssuer.addedAt();

src/api/procedures/__tests__/modifyTokenTrustedClaimIssuers.ts

@@ -44,7 +44,6 @@ describe('modifyTokenTrustedClaimIssuers procedure', () => {
     claimIssuerDids = ['aDid', 'otherDid', 'differentDid'];
     claimIssuers = claimIssuerDids.map(did => ({
       identity: new Identity({ did }, mockContext),
-      trustedFor: null,
     }));
     rawTicker = dsMockUtils.createMockTicker(ticker);
     rawClaimIssuers = claimIssuerDids.map(did =>

src/types/index.ts

@@ -310,9 +310,9 @@ export interface ClaimScope {
 export interface TrustedClaimIssuer {
   identity: Identity;
   /**
-   * a null value means that the issuer is trusted for all claim types
+   * an undefined value means that the issuer is trusted for all claim types.
    */
-  trustedFor: ClaimType[] | null;
+  trustedFor?: ClaimType[];
 }
 
 export enum ConditionType {

src/utils/__tests__/conversion.ts

@@ -3936,7 +3936,6 @@ describe('trustedClaimIssuerToTrustedIssuer and trustedIssuerToTrustedClaimIssue
 
     let issuer: TrustedClaimIssuer = {
       identity: entityMockUtils.getIdentityInstance({ did }),
-      trustedFor: null,
     };
 
     dsMockUtils
@@ -3972,7 +3971,6 @@ describe('trustedClaimIssuerToTrustedIssuer and trustedIssuerToTrustedClaimIssue
     const context = dsMockUtils.getContextInstance();
     let fakeResult: TrustedClaimIssuer = {
       identity: new Identity({ did }, context),
-      trustedFor: null,
     };
     let trustedIssuer = dsMockUtils.createMockTrustedIssuer({
       issuer: dsMockUtils.createMockIdentityId(did),

src/utils/conversion.ts

@@ -2025,7 +2025,7 @@ export function trustedIssuerToTrustedClaimIssuer(
 
   const identity = new Identity({ did: identityIdToString(issuer) }, context);
 
-  let trustedFor: ClaimType[] | null = null;
+  let trustedFor: ClaimType[] | undefined;
 
   if (claimTypes.isSpecific) {
     trustedFor = claimTypes.asSpecific.map(meshClaimTypeToClaimType);