feat: 🎸 Make unsupported versions an warning instead of error

PolymeshAssociation · Mar 3, 2022 · e6da7bd · e6da7bd
1 parent 7586851
commit e6da7bd
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 11 deletions.
diff --git a/src/Polymesh.ts b/src/Polymesh.ts
@@ -190,7 +190,16 @@ export class Polymesh {
     } = params;
     let context: Context;
 
-    await assertExpectedChainVersion(nodeUrl);
+    await assertExpectedChainVersion(nodeUrl).catch(error => {
+      if (
+        error instanceof PolymeshError &&
+        error.message.includes('Unsupported Polymesh version')
+      ) {
+        console.warn(error.message);
+      } else {
+        throw error;
+      }
+    });
 
     try {
       const { types, rpc } = schema;

diff --git a/src/__tests__/Polymesh.ts b/src/__tests__/Polymesh.ts
@@ -219,25 +219,38 @@ describe('Polymesh Class', () => {
       });
     });
 
-    test('should throw an error if the Polymesh version does not satisfy the supported version range', async () => {
+    test('should warn if the Polymesh version does not satisfy the supported version range', async () => {
       const error = new PolymeshError({
         code: ErrorCode.FatalError,
         message: 'Unsupported Polymesh version. Please upgrade the SDK',
         data: { supportedVersionRange: SUPPORTED_VERSION_RANGE },
       });
       versionStub.rejects(error);
+      const warn = jest.spyOn(console, 'warn').mockImplementation(() => {
+        // no-op
+      });
 
-      let err;
-      try {
-        await Polymesh.connect({
+      await expect(
+        Polymesh.connect({
           nodeUrl: 'wss://some.url',
-        });
-      } catch (e) {
-        err = e;
-      }
+        })
+      ).resolves.not.toThrow();
+      expect(warn).toBeCalled();
+      warn.mockRestore();
+    });
 
-      expect(err.message).toBe('Unsupported Polymesh version. Please upgrade the SDK');
-      expect(err.data.supportedVersionRange).toBe(SUPPORTED_VERSION_RANGE);
+    test('should throw an error if the Polymesh version check could not connect to the node', async () => {
+      const error = new PolymeshError({
+        code: ErrorCode.FatalError,
+        message: 'Unable to connect',
+      });
+      versionStub.rejects(error);
+
+      return expect(
+        Polymesh.connect({
+          nodeUrl: 'wss://some.url',
+        })
+      ).rejects.toThrowError(error);
     });
 
     test('should throw an error if the middleware credentials are incorrect', async () => {