feat: add dti to asset identifier enum. MSDK-287

PolymeshAssociation · Sep 24, 2020 · fb3bd93 · fb3bd93
1 parent fc2e4a8
commit fb3bd93
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 20 deletions.
diff --git a/src/api/entities/SecurityToken/__tests__/index.ts b/src/api/entities/SecurityToken/__tests__/index.ts
@@ -239,9 +239,11 @@ describe('SecurityToken class', () => {
     let isinValue: string;
     let cusipValue: string;
     let cinsValue: string;
+    let dtiValue: string;
     let isinMock: AssetIdentifier;
     let cusipMock: AssetIdentifier;
     let cinsMock: AssetIdentifier;
+    let dtiMock: AssetIdentifier;
     let tokenIdentifiers: TokenIdentifier[];
 
     let rawIdentifiers: [IdentifierType, AssetIdentifier][];
@@ -259,9 +261,11 @@ describe('SecurityToken class', () => {
       isinValue = 'FAKE ISIN';
       cusipValue = 'FAKE CUSIP';
       cinsValue = 'FAKE CINS';
+      dtiValue = 'FAKE DTI';
       isinMock = dsMockUtils.createMockAssetIdentifier(isinValue);
       cusipMock = dsMockUtils.createMockAssetIdentifier(cusipValue);
       cinsMock = dsMockUtils.createMockAssetIdentifier(cinsValue);
+      dtiMock = dsMockUtils.createMockAssetIdentifier(dtiValue);
       tokenIdentifiers = [
         {
           type: TokenIdentifierType.Isin,
@@ -275,6 +279,10 @@ describe('SecurityToken class', () => {
           type: TokenIdentifierType.Cins,
           value: cinsValue,
         },
+        {
+          type: TokenIdentifierType.Dti,
+          value: dtiValue,
+        },
       ];
 
       rawIdentifiers = tokenIdentifiers.map(({ type, value }) =>
@@ -309,14 +317,15 @@ describe('SecurityToken class', () => {
 
     test('should return the list of token identifiers for a security token', async () => {
       dsMockUtils.createQueryStub('asset', 'identifiers', {
-        multi: [isinMock, cusipMock, cinsMock],
+        multi: [isinMock, cusipMock, cinsMock, dtiMock],
       });
 
       const result = await securityToken.getIdentifiers();
 
       expect(result[0].value).toBe(isinValue);
       expect(result[1].value).toBe(cusipValue);
       expect(result[2].value).toBe(cinsValue);
+      expect(result[3].value).toBe(dtiValue);
     });
 
     test('should allow subscription', async () => {

diff --git a/src/testUtils/mocks/dataSources.ts b/src/testUtils/mocks/dataSources.ts
@@ -1443,7 +1443,7 @@ export const createMockAuthIdentifier = (authIdentifier?: {
  * NOTE: `isEmpty` will be set to true if no value is passed
  */
 export const createMockIdentifierType = (
-  identifierType?: 'Isin' | 'Cusip' | 'Cins'
+  identifierType?: 'Isin' | 'Cusip' | 'Cins' | 'Dti'
 ): IdentifierType => {
   return createMockEnum(identifierType) as IdentifierType;
 };

diff --git a/src/types/index.ts b/src/types/index.ts
@@ -129,6 +129,7 @@ export enum TokenIdentifierType {
   Isin = 'Isin',
   Cusip = 'Cusip',
   Cins = 'Cins',
+  Dti = 'Dti',
 }
 
 // NOTE: query.asset.identifiers doesn’t support custom identifier types properly for now

diff --git a/src/utils/__tests__/index.ts b/src/utils/__tests__/index.ts
@@ -881,6 +881,12 @@ describe('tokenIdentifierTypeToIdentifierType and identifierTypeToString', () =>
 
     result = identifierTypeToString(identifierType);
     expect(result).toEqual(fakeResult);
+
+    fakeResult = TokenIdentifierType.Dti;
+    identifierType = dsMockUtils.createMockIdentifierType(fakeResult);
+
+    result = identifierTypeToString(identifierType);
+    expect(result).toEqual(fakeResult);
   });
 });
 

diff --git a/src/utils/index.ts b/src/utils/index.ts
@@ -35,7 +35,6 @@ import {
   FundingRoundName,
   IdentifierType,
   IdentityId,
-  IssueAssetItem,
   Permission as MeshPermission,
   PosRatio,
   ProposalState as MeshProposalState,
@@ -70,7 +69,6 @@ import {
   IdentityWithClaims,
   isMultiClaimCondition,
   isSingleClaimCondition,
-  IssuanceData,
   KnownTokenType,
   MultiClaimCondition,
   NextKey,
@@ -636,8 +634,11 @@ export function identifierTypeToString(type: IdentifierType): string {
   if (type.isIsin) {
     return TokenIdentifierType.Isin;
   }
+  if (type.isCins) {
+    return TokenIdentifierType.Cins;
+  }
 
-  return TokenIdentifierType.Cins;
+  return TokenIdentifierType.Dti;
 }
 
 /**
@@ -1105,21 +1106,6 @@ export function textToString(value: Text): string {
   return value.toString();
 }
 
-/**
- * @hidden
- */
-export function issuanceDataToIssueAssetItem(
-  issuanceData: IssuanceData,
-  context: Context
-): IssueAssetItem {
-  const { identity, amount } = issuanceData;
-  return context.polymeshApi.createType('IssueAssetItem', {
-    // eslint-disable-next-line @typescript-eslint/camelcase
-    identity_did: stringToIdentityId(signerToString(identity), context),
-    value: numberToBalance(amount, context),
-  });
-}
-
 /**
  * @hidden
  */