feat: 🎸 Add Claim typeguards #668
Conversation
Add typeguard functions to cast Claims into specific types BREAKING CHANGE: 🧨 isSingleClaimCondition and isMultiClaimCondition moved from `src/types/index.ts` to `src/utils/typeguards.ts`
BREAKING CHANGE: 🧨 Moved isPortfolioCustodianRole, isVenueOwnerRole, isCddProviderRole, isTickerOwnerRole, isIdentityRole from `src/types/index.ts` to `src/utils/typeguards.ts`
polymath-eric
requested review from
monitz87 and
VictorVicente
as code owners
|
@monitz87 you can review this now |
|
Looks like the merge commit + auto format caused a bunch of brackets to be added in. Looking into it. |
|
Edit: The diff is cleaned up now. So looks like the batch PR had some files with the newer prettier, but not all of them. Made a PR for upgrading: https://github.com/PolymathNetwork/polymesh-sdk/pull/678/files so if that gets approved I can merge that in, and get rid of the white space noise here. I don't think there is an easy way to clean up the noise with alpha only having it partially done. |
Prevents a breaking change by using the current abbreviated form of CddClaim
|
Other than the type/interface thing, LGTM |
Convert claim types to use interfaces instead of types to be more inline with the rest of the codebase BREAKING CHANGE: 🧨 InvestorUniqueness, InvestorUniqunessV2, CddClaim converted from type to interface
|
Kudos, SonarCloud Quality Gate passed! |
|
🎉 This PR is included in version 13.0.0-alpha.19 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 14.0.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 14.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 14.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Add typeguard functions to cast Claims into specific types
BREAKING CHANGE: 🧨 isSingleClaimCondition, isMultiClaimCondition, isPortfolioCustodianRole, isVenueOwnerRole, isCddProviderRole, isTickerOwnerRole, isIdentityRole moved from
src/types/index.tstosrc/utils/typeguards.ts