This repository has been archived by the owner on Mar 13, 2018. It is now read-only.
Add workaround for broken Safari 8 DOM #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL |
|
LGTM, maybe add a link to the bug? https://bugs.webkit.org/show_bug.cgi?id=49739 |
Safari's DOM is broken. It is returns invalid descriptors. We therefore treat all properties as read-write even if they are really read only. Fixes https://github.com/Polymer/platform/issues/66
|
Added a comment explaining what the hell is going on and added a link to the webkit bug. |
arv
added a commit
that referenced
this pull request
Sep 9, 2014
Add workaround for broken Safari 8 DOM
|
nice comment 👍 |
|
👍 |
addyosmani
referenced
this pull request
in tjsavage/polymer-blog
Sep 19, 2014
svn2github
pushed a commit
to svn2github/Dart
that referenced
this pull request
Sep 22, 2014
BUG= http://dartbug.com/21033 Review URL: https://codereview.chromium.org//587423002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40543 260f80e4-7a28-3924-810f-c04153c831b5
jakemac53
added a commit
to dart-archive/bleeding_edge-DEPRECATED-USE-SDK-INSTEAD
that referenced
this pull request
Sep 22, 2014
BUG= http://dartbug.com/21033 Review URL: https://codereview.chromium.org//587423002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40543 260f80e4-7a28-3924-810f-c04153c831b5
jakemac53
added a commit
to dart-archive/web-components
that referenced
this pull request
Dec 20, 2014
BUG= http://dartbug.com/21033 Review URL: https://codereview.chromium.org//587423002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart/pkg/web_components@40543 260f80e4-7a28-3924-810f-c04153c831b5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safari's DOM is broken. It is returns invalid descriptors. We therefore
treat all properties as read-write even if they are really read only.
Fixes https://github.com/Polymer/platform/issues/66