Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shady-render in 0.11.3 interferes with setting values on parts #505

Closed
sorvell opened this issue Sep 14, 2018 · 0 comments · Fixed by #506
Closed

shady-render in 0.11.3 interferes with setting values on parts #505

sorvell opened this issue Sep 14, 2018 · 0 comments · Fixed by #506
Assignees
@sorvell

Comments

@sorvell
Copy link
Member

sorvell commented Sep 14, 2018

Recently shady-render was changed such that it added a document fragment via insertNodeIntoTemplate but this function does not currently support inserting a document fragment. The result is that updating parts fails.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sorvell sorvell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issues with shady-render introduced in 0.11.3 lit/lit
1 participant
@sorvell