Add nothing sentinel #673
Merged
Add nothing sentinel #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well this is awkward, calling |
|
|
|
I was worried that the markers would prevent rendering the fallback content. Turns out they don't: https://codepen.io/ruphin/pen/bQZdYN?editors=1010 That means this implementation will work. I will update the tests to verify that no non-comment nodes remain after rendering |
justinfagnani
approved these changes
Dec 20, 2018
neuronetio
pushed a commit
to neuronetio/lit-html
that referenced
this pull request
Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #652
Also added a small test for the
noChangesentinel.