Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version global #790

Merged
merged 5 commits into from
Feb 5, 2019
Merged

Add version global #790

merged 5 commits into from
Feb 5, 2019

Conversation

justinfagnani
Copy link
Collaborator

Fixes #788

Copy link
Member

@sorvell sorvell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after updating comment.

src/lit-html.ts Outdated

// IMPORTANT: do not change the property name or the assignment expression.
// This line will be used in regexes to search for lit-html usage.
// TODO: inject version number
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// TODO: inject version number
// TODO(justinfagnani): inject version number at build time

@justinfagnani justinfagnani merged commit 26c71d8 into master Feb 5, 2019
@justinfagnani justinfagnani deleted the version branch February 5, 2019 01:48
neuronetio pushed a commit to neuronetio/lit-html that referenced this pull request Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants