Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for comment bindings #860

Closed
wants to merge 1 commit into from
Closed

Conversation

ruphin
Copy link
Contributor

@ruphin ruphin commented Mar 5, 2019

This adds a test that is currently failing due to incorrect processing of bindings in comments:

html`<p>${'foo'}<!-- ${'baz'} -->${'bar'}</p>`;

// renders: <p>foo -->bar</p>

Reproduction:
https://codepen.io/ruphin/pen/jJVrXd?editors=1010

@mihaisavezi
Copy link

so it's a bug

@justinfagnani justinfagnani mentioned this pull request Apr 1, 2019
6 tasks
@jridgewell
Copy link
Contributor

Closed by #882

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants