Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundled entrypoints are actually emitted *twice* (once in original form, once in bundled form) #1263

Closed
usergenic opened this issue Mar 22, 2017 · 2 comments

Comments

@usergenic
Copy link
Contributor

The BuildBundler transform stream sends everything through and then after it bundles, it sends the bundle files through, typically with the same name as the fragment.

Example:

project.sources().*      project.bundler().*
- fragment1.html         - fragment1.html
- fragment2.html     =>  - fragment2.html
- script.js              - script.js
                         - fragment1.html
                         - fragment2.html

In practice, this is not causing problems for people, because the subsequent bundled files wind up overwriting the previous ones in a typical gulp stream setup. But when this winds up causing problems it may be very confusing to our users to diagnose and correct.

For this reason, we need to stop the output of bundled filenames. The downside is that the naive fix will be to hold up all html files in the stream until after bundling, which creates a bottleneck, but fixing this will dovetail with a fix for https://github.com/Polymer/polymer-build/issues/70 anyways.

@usergenic usergenic self-assigned this Mar 22, 2017
@usergenic
Copy link
Contributor Author

cc @FredKSchott

@usergenic
Copy link
Contributor Author

Working on a solution for this, but will depend on Polymer/polymer-bundler#464

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants