Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compile="true" configuration setting ignored when building 'by name' #2495

Open
ghost opened this issue Jul 19, 2017 · 3 comments
Open

compile="true" configuration setting ignored when building 'by name' #2495

ghost opened this issue Jul 19, 2017 · 3 comments

Comments

@ghost
Copy link

ghost commented Jul 19, 2017

Versions & Environment

  • Polymer CLI: 1.3.1
  • node: v6.10.1
  • Operating System: Windows 10

Steps to Reproduce

  • Start with a command prompt in a new empty directory
  • Execute a polymer init, choosing polymer-2-application (any application will do)
  • Open polymer.json, and add a build configuration, to have in the end this result:
{
 "lint": {
   "rules": [
     "polymer-2"
   ]
 },
 "builds": [
    {
      "name": "test",
      "bundle": true,
      "js": {
        "minify": true,
        "compile": true
      },
      "css": {
        "minify": true
      },
      "html": {
        "minify": true
      }
    }
 ]
}
  • Now, from the command line:
    polymer build
    Will produce the correct result (application compiled from ES6 to ES5, see build/test directory)
    polymer build --name test
    Will produce a wrong result (application NOT compiled from ES6 to ES5, see build/test directory)
@ghost
Copy link
Author

ghost commented Jul 19, 2017

This is the bare minimum scenario, of course, but any combination of build configurations and/or preset builds will exhibit this problem.
The only exception is when calling the build by preset, like in polymer build --preset es5-bundled, that creates the correct result.

@davidmaxwaterman
Copy link

I also hit what I presume is this problem recently when I had 👍

 20   "builds": [
 21     {
 22       "preset": "es5-bundled"
 23     },
 24     {
 25       "preset": "es6-bundled"
 26     },
 27     {
 28       "preset": "es6-unbundled"
 29     },
 30     {
 31       "name": "es5-unbundled",
 32       "js": {
 33         "minify": false,
 34         "compile": true
 35       },
 36       "css": {"minify": true},
 37       "html": {"minify": true},
 38       "addServiceWorker": true
 39     }

With this, polymer build --name es5-unbundled doesn't work (doesn't copy the service worker, for a start). Removing the presets so there is only es5-unbundled, works fine with polymer build.

alber70g referenced this issue in alber70g/polymer-cli Nov 16, 2017
alber70g referenced this issue in alber70g/polymer-cli Nov 17, 2017
alber70g referenced this issue in alber70g/polymer-cli Nov 17, 2017
alber70g referenced this issue in alber70g/polymer-cli Nov 17, 2017
@aomarks aomarks transferred this issue from Polymer/polymer-cli Jan 3, 2019
@stale
Copy link

stale bot commented Mar 3, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants