Skip to content

Commit

Permalink
Ensure fromAbove in _forwardParentProp.
Browse files Browse the repository at this point in the history
The general rule here is: `_forwardParentProp/Path` must assume fromAbove
is true; for `_forwardInstanceProp/Path` assume fromAbove is false.
  • Loading branch information
kaste committed Apr 16, 2016
1 parent c0e0a73 commit 072dcff
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/lib/template/dom-if.html
Expand Up @@ -169,7 +169,7 @@
// notifying parent.<prop> path change on instance
_forwardParentProp: function(prop, value) {
if (this._instance) {
this._instance[prop] = value;
this._instance.__setProperty(prop, value, true);
}
},

Expand Down
4 changes: 2 additions & 2 deletions test/unit/templatizer-elements.html
Expand Up @@ -97,7 +97,7 @@
},
_forwardParentProp: function(prop, value) {
if (this.instance) {
this.instance[prop] = value;
this.instance.__setProperty(prop, value, true);
}
},
_forwardParentPath: function(path, value) {
Expand Down Expand Up @@ -165,7 +165,7 @@
},
_forwardParentProp: function(prop, value) {
if (this.instance) {
this.instance[prop] = value;
this.instance.__setProperty(prop, value, true);
}
},
_forwardParentPath: function(path, value) {
Expand Down

0 comments on commit 072dcff

Please sign in to comment.